From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKzjx-00086R-EE for qemu-devel@nongnu.org; Wed, 06 Jul 2016 23:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKzjs-0006Av-B6 for qemu-devel@nongnu.org; Wed, 06 Jul 2016 23:12:36 -0400 Received: from [59.151.112.132] (port=41073 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKzjr-00068O-JE for qemu-devel@nongnu.org; Wed, 06 Jul 2016 23:12:32 -0400 References: <1467774199-21807-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20160706064650.GB16605@ad.usersys.redhat.com> <577CB746.10300@cn.fujitsu.com> <20160707003107.GA4208@ad.usersys.redhat.com> From: Cao jin Message-ID: <577DCA1C.2020809@cn.fujitsu.com> Date: Thu, 7 Jul 2016 11:18:52 +0800 MIME-Version: 1.0 In-Reply-To: <20160707003107.GA4208@ad.usersys.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On 07/07/2016 08:31 AM, Fam Zheng wrote: > On Wed, 07/06 15:46, Cao jin wrote: >> > > Yes, but in this patch I think the blank line changes are 1) more of personal > taste, 2) completely unrelated (neither lines nor semantics) to the functional > change. > > Fam Indeed, my personal taste. Generally speaking, well separated code block is easier for newbies to read. This is what I has been trained before, and I like it, so I just can't help to add these lines when the code in my hand:P BTW, I am curious about maintainer`s opinion about this thing:) -- Yours Sincerely, Cao jin