From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLANB-0003Ra-Fa for qemu-devel@nongnu.org; Thu, 07 Jul 2016 10:33:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLAN6-0003BD-H0 for qemu-devel@nongnu.org; Thu, 07 Jul 2016 10:33:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLAN6-0003Ao-8z for qemu-devel@nongnu.org; Thu, 07 Jul 2016 10:33:44 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6822A8E3E5 for ; Thu, 7 Jul 2016 14:33:43 +0000 (UTC) References: <1467890865-8553-1-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <577E6844.3030909@redhat.com> Date: Thu, 7 Jul 2016 08:33:40 -0600 MIME-Version: 1.0 In-Reply-To: <1467890865-8553-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4ifJiCREi2WPUnmQBcgEPOshspJH066Hw" Subject: Re: [Qemu-devel] [PATCH v2] qapi: change QmpInputVisitor to QSLIST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4ifJiCREi2WPUnmQBcgEPOshspJH066Hw From: Eric Blake To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <577E6844.3030909@redhat.com> Subject: Re: [PATCH v2] qapi: change QmpInputVisitor to QSLIST References: <1467890865-8553-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1467890865-8553-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2016 05:27 AM, Paolo Bonzini wrote: > This saves a lot of memory compared to a statically-sized array, > or at least 24kb could be considered a lot on an Atari ST. >=20 > It also makes the code more similar to QmpOutputVisitor. >=20 > Signed-off-by: Paolo Bonzini > --- > v1->v2: leave assert in check_struct [Eric, Markus] >=20 > qapi/qmp-input-visitor.c | 54 ++++++++++++++++++++++++----------------= -------- > 1 file changed, 27 insertions(+), 27 deletions(-) >=20 > -static void qmp_input_pop(Visitor *v) > +static void qmp_input_stack_pop(QmpInputVisitor *qiv) > { > - QmpInputVisitor *qiv =3D to_qiv(v); > - StackObject *tos =3D &qiv->stack[qiv->nb_stack - 1]; > - > +} > + > +static void qmp_input_pop(Visitor *v) > +{ > + QmpInputVisitor *qiv =3D to_qiv(v); > + > + qmp_input_stack_pop(qiv); > } I'm not entirely convinced we needed to separate qmp_input_pop() from qmp_input_stack_pop(), but I'm not opposed to it enough to stop review. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4ifJiCREi2WPUnmQBcgEPOshspJH066Hw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXfmhEAAoJEKeha0olJ0Nqa0wH/jBMzmlDDHN/77CDSZCEuioZ Ql7urou68qbOKcOmDc9cUxGPNZ6gr9f118Ih1o+Y3w0lFuFTUW2Xamfmxfqe6P1i Jj19HXJtPnFe0l8Bf5nHcrIG+x/jj04r+3CdR/rqclCQddDwPE9+X7tKqtHwCBX7 PoKrtoDk8HoTXE3sK4lgruW3inFEu/5VMUUDZCIanUi23rQw/eK2PSjLJTZropku gV9no8X8eVQJ5REPHDQ9o2HKpMTJEBB7lGoyn/O5ZJd1l1SAiHKWBcmTNtvc7wda Y9n+jN5P7IyqjcYiXdPHw+y1ku4U/az2/XD2/zM7LuybultZ8d8m2eJhn0SUtT8= =p00h -----END PGP SIGNATURE----- --4ifJiCREi2WPUnmQBcgEPOshspJH066Hw--