From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bLMTm-0002Mz-HM
	for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:29:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bLMTi-0004E8-BH
	for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:29:25 -0400
Received: from mail-db5eur01on0135.outbound.protection.outlook.com
	([104.47.2.135]:53120
	helo=EUR01-DB5-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bLMTh-0004E2-Ni
	for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:29:22 -0400
References: <1466765376-25722-1-git-send-email-den@openvz.org>
	<20160707164448.GE4131@thinpad.lan.raisama.net>
	<20160707164904.GF4131@thinpad.lan.raisama.net>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <577E88F8.5010102@openvz.org>
Date: Thu, 7 Jul 2016 19:53:12 +0300
MIME-Version: 1.0
In-Reply-To: <20160707164904.GF4131@thinpad.lan.raisama.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fixup! cpu: report hyperv feature words
 through qom
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Evgeny Yakovlev <eyakovlev@virtuozzo.com>, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On 07/07/2016 07:49 PM, Eduardo Habkost wrote:
> On Thu, Jul 07, 2016 at 01:44:48PM -0300, Eduardo Habkost wrote:
>> Hi,
>>
>> Sorry for taking so long to review it.
>>
>> The patch in general looks good, except for:
>>
>> On Fri, Jun 24, 2016 at 01:49:36PM +0300, Denis V. Lunev wrote:
>> [...]
>>> +    if (MACHINE_GET_CLASS(current_machine)->hot_add_cpu != NULL) {
>>> +        env->features[FEAT_HYPERV_EDX] |= HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
>>> +    }
>> [...]
>>> +}
>>> +
>> [...]
>>> -        c->edx |= HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
>> If you want to change the rules for setting
>> HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE, please do it in a
>> separate patch.
> I will apply the patch, but with the following fixup:
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   target-i386/kvm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 5df4b48..4193fe1 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -599,6 +599,7 @@ static int hyperv_handle_properties(CPUState *cs)
>       if (cpu->hyperv_crash && has_msr_hv_crash) {
>           env->features[FEAT_HYPERV_EDX] |= HV_X64_GUEST_CRASH_MSR_AVAILABLE;
>       }
> +    env->features[FEAT_HYPERV_EDX] |= HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
>       if (cpu->hyperv_reset && has_msr_hv_reset) {
>           env->features[FEAT_HYPERV_EAX] |= HV_X64_MSR_RESET_AVAILABLE;
>       }
> @@ -630,9 +631,6 @@ static int hyperv_handle_properties(CPUState *cs)
>           }
>           env->features[FEAT_HYPERV_EAX] |= HV_X64_MSR_SYNTIMER_AVAILABLE;
>       }
> -    if (MACHINE_GET_CLASS(current_machine)->hot_add_cpu != NULL) {
> -        env->features[FEAT_HYPERV_EDX] |= HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
> -    }
>       return 0;
>   }
>   
yes, you are right

Reviewed-by: Denis V. Lunev <den@openvz.org>