From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLE4X-0005HB-H4 for qemu-devel@nongnu.org; Thu, 07 Jul 2016 14:30:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLE4U-00015B-AV for qemu-devel@nongnu.org; Thu, 07 Jul 2016 14:30:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLE4T-000152-Vl for qemu-devel@nongnu.org; Thu, 07 Jul 2016 14:30:46 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD6FFC04B306 for ; Thu, 7 Jul 2016 18:30:43 +0000 (UTC) References: <1467906798-5312-1-git-send-email-pbonzini@redhat.com> <1467906798-5312-3-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <577E9FD1.7060509@redhat.com> Date: Thu, 7 Jul 2016 12:30:41 -0600 MIME-Version: 1.0 In-Reply-To: <1467906798-5312-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="diKspefFKoTIjlEvBHb89ot91LF9JEisF" Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: change QmpInputVisitor to QSLIST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --diKspefFKoTIjlEvBHb89ot91LF9JEisF From: Eric Blake To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <577E9FD1.7060509@redhat.com> Subject: Re: [PATCH v3 2/2] qapi: change QmpInputVisitor to QSLIST References: <1467906798-5312-1-git-send-email-pbonzini@redhat.com> <1467906798-5312-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1467906798-5312-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2016 09:53 AM, Paolo Bonzini wrote: > This saves a lot of memory compared to a statically-sized array, > or at least 24kb could be considered a lot on an Atari ST. > It also makes the code more similar to QmpOutputVisitor. >=20 > This removes the limit on the depth of a QObject that can be processed > into a QAPI tree. This is not a problem because QObjects can be > considered truested; the text received on the QMP wire is untrusted s/truested/trusted/ > input, but the JSON parser already takes pains to limit the QObject tre= e > it creates. We don't need the QMP input visitor to limit it again. >=20 > Signed-off-by: Paolo Bonzini > --- > qapi/qmp-input-visitor.c | 59 ++++++++++++++++++++++++----------------= -------- > 1 file changed, 29 insertions(+), 30 deletions(-) >=20 With commit message tweak here and comment tweak in 1/2, Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --diKspefFKoTIjlEvBHb89ot91LF9JEisF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXfp/RAAoJEKeha0olJ0NqDB0H/jLOJNlDbyz5gVQpC5e1meVH I7C54HvpIvOR4F1R0G7SFAIWqCmCnpM9sn1Njer1vjQhGvvnXdsoq/basukbgx6K mXGE2WRAIfTZMV0lDrpz0l+Ui9jBefNh/qse7I1RPNreX2qqDKO3GWCqo63IwNNU A/N2LwBDDHzrkK4evCra7FwCGCecVwLdoB5pf1Y6hPjzEkIPQREzA88lSaJBfXUn eVChXWBjyaCJ6mzzU+77POtn5a5k9XaTUIPs/BKVH0KCTTYdc2ZmmMY3zhioNwxW v+DMe41zbpBlnsDZh4weF9dYCksfx5iyXhAJLxSwg6qV/1W3/8i+6dDMnwJnNSs= =KSoe -----END PGP SIGNATURE----- --diKspefFKoTIjlEvBHb89ot91LF9JEisF--