From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLI2w-0002lG-Hg for qemu-devel@nongnu.org; Thu, 07 Jul 2016 18:45:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLI2v-000477-HZ for qemu-devel@nongnu.org; Thu, 07 Jul 2016 18:45:26 -0400 References: <1467893497-2434-1-git-send-email-kwolf@redhat.com> <1467893497-2434-2-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <577EDB7D.6030102@redhat.com> Date: Thu, 7 Jul 2016 16:45:17 -0600 MIME-Version: 1.0 In-Reply-To: <1467893497-2434-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jw5C1Rpvu9A3VhE1INRhgbfIlw9mrtw6U" Subject: Re: [Qemu-devel] [PATCH v3 01/11] block: Accept node-name for block-stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jw5C1Rpvu9A3VhE1INRhgbfIlw9mrtw6U From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org Message-ID: <577EDB7D.6030102@redhat.com> Subject: Re: [PATCH v3 01/11] block: Accept node-name for block-stream References: <1467893497-2434-1-git-send-email-kwolf@redhat.com> <1467893497-2434-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1467893497-2434-2-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2016 06:11 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-stream to accept a node-name without lifting the restriction that= > we're operating at a root node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 32 ++++++++++++++++++++------------ > qapi/block-core.json | 5 +---- > qmp-commands.hx | 2 +- > tests/qemu-iotests/030 | 2 +- > 4 files changed, 23 insertions(+), 18 deletions(-) >=20 The interface change looks okay; but due to Berto's comments, I'm not sure it is worth giving R-b yet if you plan on changing the check for whether a node name properly qualifies as a root name. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Jw5C1Rpvu9A3VhE1INRhgbfIlw9mrtw6U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXftt9AAoJEKeha0olJ0NqpNIIAIzZY54tmN4I+NLx2AQrs9bs bkg84fhRxfMzmpeLgWoAatbw/nBNdqZxjUa3DgTi+4M1mWsP12iQmh5Jx7JbJOZ/ 1E1GIdWFbWhfP4LwJ7pLvJtLD28EUxxESTO8PmElLhGYNRhVrlcUh3QcZXdL4ut2 Y3qYYtz36X08WEch7VVpFSybxHNqBtTj7+/0XEg713HGWHUsFDsSSO1d8Go1d/nb /5Kj6mpKjS1SlmUoepEDoodefltVyanMHNjMaEOuVhSqzhS0WcR99Q76PDAQv5OG zBDsc46hbUZX5lFnpbiQWtvXzuQRGQa07jCUbaaCH39HVMkgYFLMyazEKnaU2eI= =eRU2 -----END PGP SIGNATURE----- --Jw5C1Rpvu9A3VhE1INRhgbfIlw9mrtw6U--