From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLIAp-0000Wr-4b for qemu-devel@nongnu.org; Thu, 07 Jul 2016 18:53:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLIAm-0005MJ-TC for qemu-devel@nongnu.org; Thu, 07 Jul 2016 18:53:34 -0400 References: <1467893497-2434-1-git-send-email-kwolf@redhat.com> <1467893497-2434-3-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <577EDD47.4050300@redhat.com> Date: Thu, 7 Jul 2016 16:52:55 -0600 MIME-Version: 1.0 In-Reply-To: <1467893497-2434-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vUg2tGnwSiMT9HRPnkBEHQX4qPgdwxUuG" Subject: Re: [Qemu-devel] [PATCH v3 02/11] block: Accept node-name for block-commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vUg2tGnwSiMT9HRPnkBEHQX4qPgdwxUuG From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org Message-ID: <577EDD47.4050300@redhat.com> Subject: Re: [PATCH v3 02/11] block: Accept node-name for block-commit References: <1467893497-2434-1-git-send-email-kwolf@redhat.com> <1467893497-2434-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1467893497-2434-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2016 06:11 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-commit to accept a node-name without lifting the restriction that= > we're operating at a root node. >=20 > As libvirt makes use of the DeviceNotFound error class, we must add > explicit code to retain this behaviour because qmp_get_root_bs() only > returns GenericErrors. Indeed, and good thing we had the comment in the code to remind us. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 23 +++++++++++------------ > qapi/block-core.json | 5 ++--- > qmp-commands.hx | 2 +- > 3 files changed, 14 insertions(+), 16 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1004,7 +1004,7 @@ > # Live commit of data from overlay image nodes into backing nodes - i.= e., > # writes data between 'top' and 'base' into 'base'. > # > -# @device: the name of the device > +# @device: the device name or node-name of a root node > # > # @base: #optional The file name of the backing image to write data = into. > # If not specified, this is the deepest backing ima= ge > @@ -1046,9 +1046,8 @@ > # > # Returns: Nothing on success > # If commit or stream is already active on this device, Devic= eInUse > -# If @device does not exist, DeviceNotFound Except deleting this line is at odds with the special casing you added. > # If image commit is not supported by this device, NotSupport= ed > -# If @base or @top is invalid, a generic error is returned > +# If @device, @base or @top is invalid, a generic error is re= turned > # If @speed is invalid, InvalidParameter > # --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vUg2tGnwSiMT9HRPnkBEHQX4qPgdwxUuG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXft1HAAoJEKeha0olJ0NqxZMH+gPv+kNGMHQg4Q0OSDR3vRd3 pfAJa0PtopfE00am5PZgGK+bcdzpg0necWo6W6phSnV2RPifi7htrR/HJJYZXuaB RQ8Z0QdPSMRqvxhsGiYz9+T0UMNgGuaPDtVuABjJWAxfdyU80MRTXZSkDJABmUHr VRkA/kd6Mn/FCtr3rPAuWaxUZafA6vD3Fwfp/2bb5V+Aen+XGDw5299A4WDzZFGG U4PvcTwrwSZvPfgisCd49fDMnDTMAjxvwFVrRK9ui3BGRH04phz8C1m4b7GJW2u1 a/lC/26HFc3CcbLVCkcVI43RmIg/NYNKJkm/iBVbca0JrUWsoi1ZaOuobWMd0AE= =MLMo -----END PGP SIGNATURE----- --vUg2tGnwSiMT9HRPnkBEHQX4qPgdwxUuG--