From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLWnD-0008NA-5g for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLWn8-0003wl-1I for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:30:10 -0400 References: <1467893497-2434-1-git-send-email-kwolf@redhat.com> <1467893497-2434-2-git-send-email-kwolf@redhat.com> <577EDB7D.6030102@redhat.com> <20160708100112.GH14684@noname.redhat.com> From: Eric Blake Message-ID: <577FB8E9.7030206@redhat.com> Date: Fri, 8 Jul 2016 08:30:01 -0600 MIME-Version: 1.0 In-Reply-To: <20160708100112.GH14684@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JPvhT4x9qb8mdpD5fKAI7qmIP9A77kLH5" Subject: Re: [Qemu-devel] [PATCH v3 01/11] block: Accept node-name for block-stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JPvhT4x9qb8mdpD5fKAI7qmIP9A77kLH5 From: Eric Blake To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org Message-ID: <577FB8E9.7030206@redhat.com> Subject: Re: [PATCH v3 01/11] block: Accept node-name for block-stream References: <1467893497-2434-1-git-send-email-kwolf@redhat.com> <1467893497-2434-2-git-send-email-kwolf@redhat.com> <577EDB7D.6030102@redhat.com> <20160708100112.GH14684@noname.redhat.com> In-Reply-To: <20160708100112.GH14684@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/08/2016 04:01 AM, Kevin Wolf wrote: > Am 08.07.2016 um 00:45 hat Eric Blake geschrieben: >> On 07/07/2016 06:11 AM, Kevin Wolf wrote: >>> In order to remove the necessity to use BlockBackend names in the >>> external API, we want to allow node-names everywhere. This converts >>> block-stream to accept a node-name without lifting the restriction th= at >>> we're operating at a root node. >>> >>> In case of an invalid device name, the command returns the GenericErr= or >>> error class now instead of DeviceNotFound, because this is what >>> qmp_get_root_bs() returns. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> blockdev.c | 32 ++++++++++++++++++++------------ >>> qapi/block-core.json | 5 +---- >>> qmp-commands.hx | 2 +- >>> tests/qemu-iotests/030 | 2 +- >>> 4 files changed, 23 insertions(+), 18 deletions(-) >>> >> >> The interface change looks okay; but due to Berto's comments, I'm not >> sure it is worth giving R-b yet if you plan on changing the check for >> whether a node name properly qualifies as a root name. >=20 > Initially I intended to address the comment with some change, but since= > I realised that you already can put a BB everywhere and therefore this > doesn't protect anything against intentional actions anyway, I'm not so= > sure any more. >=20 > Do you have an opintion on this? More input would be appreciated. I still need to re-read the other sub-thread closely, but yes, I'll try to chime in after I've had a chance to think about implications. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JPvhT4x9qb8mdpD5fKAI7qmIP9A77kLH5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXf7jpAAoJEKeha0olJ0Nqz8MH/0lTxNBmxreOalYMYbUc2Rsd uWwwSHAh0KW33Fymp6z6dzYm9LxDdlZJFfXMz725d8K/XCS40BV7xNydT21PLkZS Zv7TYzLJ/q4HJr8QgK6mvqihASK4UJg79zfgTxq+6LHHXnYuuI6NgetxTYLyhFje d5/JW6aaM4SRYeVnBt4ekm5xOdbLl4grVypxf9w4RcMPJqGmXVYtvllhP2cIeDou JnuqC5ttcWgsIhcPdyTh/R+k4528lrNL27VbEtn7chzayCqKU74eRDKjpW2n2mXd hVze4vLxNMxiIulfeODJeFEZdcnfuyzhJJE73p0TP6PwwlVdSQ3fw3lFN4Z0nt4= =UMkQ -----END PGP SIGNATURE----- --JPvhT4x9qb8mdpD5fKAI7qmIP9A77kLH5--