From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLWom-0001PT-DA for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLWok-0004YC-SN for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:31:47 -0400 References: <1466465969-25315-1-git-send-email-eblake@redhat.com> <1466465969-25315-2-git-send-email-eblake@redhat.com> <20160708105600.GJ14684@noname.redhat.com> From: Eric Blake Message-ID: <577FB94B.6060809@redhat.com> Date: Fri, 8 Jul 2016 08:31:39 -0600 MIME-Version: 1.0 In-Reply-To: <20160708105600.GJ14684@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rSTx9EFQeI6iJdr1GKsOiu4thG3kahcUD" Subject: Re: [Qemu-devel] [PATCH 1/5] block: Fragment reads to max transfer length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Fam Zheng , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rSTx9EFQeI6iJdr1GKsOiu4thG3kahcUD From: Eric Blake To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Fam Zheng , Max Reitz Message-ID: <577FB94B.6060809@redhat.com> Subject: Re: [PATCH 1/5] block: Fragment reads to max transfer length References: <1466465969-25315-1-git-send-email-eblake@redhat.com> <1466465969-25315-2-git-send-email-eblake@redhat.com> <20160708105600.GJ14684@noname.redhat.com> In-Reply-To: <20160708105600.GJ14684@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/08/2016 04:56 AM, Kevin Wolf wrote: > Am 21.06.2016 um 01:39 hat Eric Blake geschrieben: >> Drivers should be able to rely on the block layer honoring the >> max transfer length, rather than needing to return -EINVAL >> (iscsi) or manually fragment things (nbd). This patch adds >> the fragmentation in the block layer, after requests have been >> aligned (fragmenting before alignment would lead to multiple >> unaligned requests, rather than just the head and tail). >> >> Signed-off-by: Eric Blake >=20 > Doesn't build for me: >=20 > block/io.c: In function 'bdrv_aligned_preadv': > block/io.c:1071:5: error: 'ret' may be used uninitialized in this funct= ion [-Werror=3Dmaybe-uninitialized] > return ret; One of those annoying problems detected at -O2 but not at -O0. I'll resp= in. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rSTx9EFQeI6iJdr1GKsOiu4thG3kahcUD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXf7lLAAoJEKeha0olJ0NqIQAH/2nvhoOvPKWaN72izq8+B6bA OS4o49Z1W38vd8Dhfmdc8dbKkodkHNP0zoec6wP5e2rBtiYteCa0k3JmfuMBWRpU 6XX2fr+B7EWmwoGL5fXzNhaJJrsctfZ17ISz/uit46ZTeya7EW1cHdOdc4AVoW3U vw8N+2rc8OhrKWOs9nsesrQKdWZbSVGu/b0of6Hrc+47/FN9l+rzD4nyFUiRuGZ7 RjWLTcyRG5TDDebQFTeidAKyiekNOm8DCk4+OzA6M7gQaeQBpD/Wxygp5DQ9cpuH 7DXygZ/aWVb/ClJckbI/7QoBz0xxxTIPTWv+E5WmuOAbxWjPzFWRcdmALgsoiNU= =irMv -----END PGP SIGNATURE----- --rSTx9EFQeI6iJdr1GKsOiu4thG3kahcUD--