From: Jeuk Kim <jeuk20.kim@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, fam@euphon.net, hreitz@redhat.com,
k.jensen@samsung.com, kwolf@redhat.com, pbonzini@redhat.com,
qemu-block@nongnu.org, berrange@redhat.com,
marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com,
mst@redhat.com, philmd@linaro.org, thuth@redhat.com,
lvivier@redhat.com, jeuk20.kim@samsung.com
Subject: Re: [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support
Date: Thu, 27 Jul 2023 09:56:54 +0900 [thread overview]
Message-ID: <577a2d20-b0d5-fffd-7377-587b4dfed3ca@gmail.com> (raw)
In-Reply-To: <20230726193626.GD822884@fedora>
On 7/27/2023 4:36 AM, Stefan Hajnoczi wrote:
> On Wed, Jul 26, 2023 at 02:30:49PM +0900, Jeuk Kim wrote:
>> Since v6:
>> - Add tests/qtest/ufs-test.c to test ufs initialisation and I/O
>> - Add struct UtpTaskReqDesc to include/block/ufs.h
>> - Fix ufs_log2() logic
>> - Fix ufs-lu to use 4K as default block size to match the ufs spec
>>
>> Since I created a new file, tests/qtest/ufs-test.c, I added Laurent Vivier to the cc list.
>> Thank you.
>
> Modulo the comments about the test case:
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thank you very much for your detailed reviews so far.
I will resend the patch reflecting your comments on the test case.
Thanks again!
Jeuk
prev parent reply other threads:[~2023-07-27 1:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 5:30 [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support Jeuk Kim
2023-07-26 5:30 ` [PATCH v7 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage Jeuk Kim
2023-07-26 5:30 ` [PATCH v7 2/4] hw/ufs: Support for Query Transfer Requests Jeuk Kim
2023-07-26 5:30 ` [PATCH v7 3/4] hw/ufs: Support for UFS logical unit Jeuk Kim
2023-07-26 5:30 ` [PATCH v7 4/4] tests/qtest: Introduce tests for UFS Jeuk Kim
2023-07-26 7:21 ` Thomas Huth
2023-07-26 8:15 ` Jeuk Kim
2023-07-26 19:35 ` Stefan Hajnoczi
2023-07-26 19:36 ` [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support Stefan Hajnoczi
2023-07-27 0:56 ` Jeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577a2d20-b0d5-fffd-7377-587b4dfed3ca@gmail.com \
--to=jeuk20.kim@gmail.com \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jeuk20.kim@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).