From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] gitlab-ci: Build MSYS2 job using multiple CPUs
Date: Mon, 19 Aug 2024 15:17:23 +0200 [thread overview]
Message-ID: <5781edcf-3b1f-49d5-b835-5dbecda129b4@redhat.com> (raw)
In-Reply-To: <20240819112141.13786-1-philmd@linaro.org>
According to
https://docs.gitlab.com/ee/ci/runners/hosted_runners/windows.html the
Windows shared runner should have 2 vCPUs nowadays, indeed! Maybe worth to
mention it in the patch description?
Also, how much faster does the job now run for you?
On 19/08/2024 13.21, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> I don't know how to use Powershell do use nproc+1 jobs
> to optimize jobs waiting on I/O.
Well, we're calling into bash there, so you could do it as part of the bash
statement?
Thomas
> ---
> .gitlab-ci.d/windows.yml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
> index a83f23a786..35ccb74fee 100644
> --- a/.gitlab-ci.d/windows.yml
> +++ b/.gitlab-ci.d/windows.yml
> @@ -110,6 +110,7 @@ msys2-64bit:
> mingw-w64-x86_64-usbredir
> mingw-w64-x86_64-zstd"
> - Write-Output "Running build at $(Get-Date -Format u)"
> + - $env:JOBS = $(.\msys64\usr\bin\bash -lc nproc)
> - $env:CHERE_INVOKING = 'yes' # Preserve the current working directory
> - $env:MSYS = 'winsymlinks:native' # Enable native Windows symlink
> - $env:CCACHE_BASEDIR = "$env:CI_PROJECT_DIR"
> @@ -121,7 +122,7 @@ msys2-64bit:
> - cd build
> - ..\msys64\usr\bin\bash -lc "ccache --zero-stats"
> - ..\msys64\usr\bin\bash -lc "../configure --enable-fdt=system $CONFIGURE_ARGS"
> - - ..\msys64\usr\bin\bash -lc "make"
> + - ..\msys64\usr\bin\bash -lc "make -j$env:JOBS"
> - ..\msys64\usr\bin\bash -lc "make check MTESTARGS='$TEST_ARGS' || { cat meson-logs/testlog.txt; exit 1; } ;"
> - ..\msys64\usr\bin\bash -lc "ccache --show-stats"
> - Write-Output "Finished build at $(Get-Date -Format u)"
prev parent reply other threads:[~2024-08-19 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 11:21 [PATCH] gitlab-ci: Build MSYS2 job using multiple CPUs Philippe Mathieu-Daudé
2024-08-19 13:17 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5781edcf-3b1f-49d5-b835-5dbecda129b4@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).