From: Max Reitz <mreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 0/6] Enable more iotests during "make check-block"
Date: Mon, 20 Jan 2020 15:52:24 +0100 [thread overview]
Message-ID: <57826390-d8fd-9cfc-b3b0-e8c07e18ece1@redhat.com> (raw)
In-Reply-To: <20191202101039.8981-1-thuth@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1249 bytes --]
On 02.12.19 11:10, Thomas Huth wrote:
> As discussed here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html
>
> and here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html
>
> it would be good to have some more valuable iotests enabled in the
> "auto" group to get better iotest coverage during "make check".
>
> Since these Python-based tests require a QEMU that features a 'virtio-blk'
> device, we can only run the Python tests if this device is available. With
> binaries like qemu-system-tricore, the Python-based tests will be skipped.
>
> v4:
> - The check for 'virtio-blk' is now done in the tests/qemu-iotests/check
> script instead of tests/check-block.sh (to avoid to duplicate the code
> that searches for the right QEMU binary - and we can also still run
> the shell-based tests this way).
> - Added the new patch to check for the availability of virtio devices in
> the iotests 127 and 267.
> - The patch that drops test 130 from the "auto" group has already been
> merged and thus been dropped from this series.
Looks good to me, the only question is whether you’d like to add a
$python_unusable_because in patch 5 or not.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-20 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:10 [PATCH v4 0/6] Enable more iotests during "make check-block" Thomas Huth
2019-12-02 10:10 ` [PATCH v4 1/6] iotests: remove 'linux' from default supported platforms Thomas Huth
2019-12-02 10:10 ` [PATCH v4 2/6] iotests: Test 041 only works on certain systems Thomas Huth
2020-01-20 14:31 ` Max Reitz
2019-12-02 10:10 ` [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD Thomas Huth
2020-01-20 14:36 ` Max Reitz
2020-01-20 16:01 ` Thomas Huth
2019-12-02 10:10 ` [PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127 Thomas Huth
2020-01-20 14:47 ` Max Reitz
2019-12-02 10:10 ` [PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk Thomas Huth
2020-01-20 14:50 ` Max Reitz
2020-01-20 16:05 ` Thomas Huth
2019-12-02 10:10 ` [PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage Thomas Huth
2020-01-20 14:51 ` Max Reitz
2020-01-20 14:52 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57826390-d8fd-9cfc-b3b0-e8c07e18ece1@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).