qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] net: cleanup before character devices
Date: Mon, 11 Jul 2016 17:06:58 +0800	[thread overview]
Message-ID: <578361B2.3040608@redhat.com> (raw)
In-Reply-To: <1467991671-93391-1-git-send-email-pbonzini@redhat.com>



On 2016年07月08日 23:27, Paolo Bonzini wrote:
> Otherwise, vhost-user causes a use-after-free.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   vl.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index d0b9ff9..005162d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4327,9 +4327,6 @@ int main(int argc, char **argv, char **envp)
>           qemu_opts_del(icount_opts);
>       }
>   
> -    /* clean up network at qemu process termination */
> -    atexit(&net_cleanup);
> -
>       if (default_net) {
>           QemuOptsList *net = qemu_find_opts("net");
>           qemu_opts_set(net, NULL, "type", "nic", &error_abort);
> @@ -4596,6 +4593,9 @@ int main(int argc, char **argv, char **envp)
>   #ifdef CONFIG_TPM
>       tpm_cleanup();
>   #endif
> +
> +    /* vhost-user must be cleaned up before chardevs.  */
> +    net_cleanup();
>       qemu_chr_cleanup();
>   
>       return 0;

Patch does not seems to be applied on master. Which tree is this patch 
based?

Thanks

  parent reply	other threads:[~2016-07-11  9:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 15:27 [Qemu-devel] [PATCH] net: cleanup before character devices Paolo Bonzini
2016-07-08 15:42 ` Marc-André Lureau
2016-07-08 15:43   ` Paolo Bonzini
2016-07-11  9:06 ` Jason Wang [this message]
2016-07-11  9:18   ` Paolo Bonzini
2016-07-11 11:23     ` Jason Wang
2016-07-11 11:29       ` Paolo Bonzini
2016-07-11 12:51         ` Marc-André Lureau
2016-07-11 13:02           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578361B2.3040608@redhat.com \
    --to=jasowang@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).