From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42331)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bMZJI-00036x-Ae
	for qemu-devel@nongnu.org; Mon, 11 Jul 2016 07:23:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bMZJF-0001fM-OR
	for qemu-devel@nongnu.org; Mon, 11 Jul 2016 07:23:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42923)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bMZJF-0001fI-IP
	for qemu-devel@nongnu.org; Mon, 11 Jul 2016 07:23:33 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 3794EC05FBB4
	for <qemu-devel@nongnu.org>; Mon, 11 Jul 2016 11:23:33 +0000 (UTC)
References: <1467991671-93391-1-git-send-email-pbonzini@redhat.com>
	<578361B2.3040608@redhat.com>
	<7739c201-5561-2a00-1710-287236927a19@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <578381B1.60807@redhat.com>
Date: Mon, 11 Jul 2016 19:23:29 +0800
MIME-Version: 1.0
In-Reply-To: <7739c201-5561-2a00-1710-287236927a19@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] net: cleanup before character devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>



On 2016=E5=B9=B407=E6=9C=8811=E6=97=A5 17:18, Paolo Bonzini wrote:
>
> On 11/07/2016 11:06, Jason Wang wrote:
>>
>> On 2016=E5=B9=B407=E6=9C=8808=E6=97=A5 23:27, Paolo Bonzini wrote:
>>> Otherwise, vhost-user causes a use-after-free.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>    vl.c | 6 +++---
>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index d0b9ff9..005162d 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -4327,9 +4327,6 @@ int main(int argc, char **argv, char **envp)
>>>            qemu_opts_del(icount_opts);
>>>        }
>>>    -    /* clean up network at qemu process termination */
>>> -    atexit(&net_cleanup);
>>> -
>>>        if (default_net) {
>>>            QemuOptsList *net =3D qemu_find_opts("net");
>>>            qemu_opts_set(net, NULL, "type", "nic", &error_abort);
>>> @@ -4596,6 +4593,9 @@ int main(int argc, char **argv, char **envp)
>>>    #ifdef CONFIG_TPM
>>>        tpm_cleanup();
>>>    #endif
>>> +
>>> +    /* vhost-user must be cleaned up before chardevs.  */
>>> +    net_cleanup();
>>>        qemu_chr_cleanup();
>>>          return 0;
>> Patch does not seems to be applied on master. Which tree is this patch
>> based?
> It's applied on top of Marc-Andr=C3=A9's character device cleanup serie=
s.
>
> Paolo
>

Ok, but looks like the issue we tried to solve with commit=20
f30dbae63a46f23116715dff8d130c7d01ff02be will appear again?