From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMaTg-0002Si-FF for qemu-devel@nongnu.org; Mon, 11 Jul 2016 08:38:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMaTf-0007wh-Hs for qemu-devel@nongnu.org; Mon, 11 Jul 2016 08:38:24 -0400 References: <1467839703-11733-1-git-send-email-sergey.fedorov@linaro.org> <1467839703-11733-3-git-send-email-sergey.fedorov@linaro.org> <578392D2.6050704@de.ibm.com> From: Sergey Fedorov Message-ID: <57839336.4010403@gmail.com> Date: Mon, 11 Jul 2016 15:38:14 +0300 MIME-Version: 1.0 In-Reply-To: <578392D2.6050704@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Sergey Fedorov , qemu-devel@nongnu.org Cc: MTTCG Devel , =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= , Alvise Rigo , "Emilio G. Cota" , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Richard Henderson , Peter Maydell , Peter Crosthwaite , Eduardo Habkost , "Michael S. Tsirkin" , David Gibson , Alexander Graf , Marcelo Tosatti , Cornelia Huck , qemu-ppc@nongnu.org, kvm@vger.kernel.org On 11/07/16 15:36, Christian Borntraeger wrote: > On 07/06/2016 11:14 PM, Sergey Fedorov wrote: >> From: Alex Bennée >> >> CPUState is a fairly common pointer to pass to these helpers. This means >> if you need other arguments for the async_run_on_cpu case you end up >> having to do a g_malloc to stuff additional data into the routine. For >> the current users this isn't a massive deal but for MTTCG this gets >> cumbersome when the only other parameter is often an address. >> >> This adds the typedef run_on_cpu_func for helper functions which has an >> explicit CPUState * passed as the first parameter. All the users of >> run_on_cpu and async_run_on_cpu have had their helpers updated to use >> CPUState where available. >> >> Signed-off-by: Alex Bennée >> [Sergey Fedorov: >> - eliminate more CPUState in user data; >> - remove unnecessary user data passing; >> - fix target-s390x/kvm.c and target-s390x/misc_helper.c] >> Signed-off-by: Sergey Fedorov >> --- >> >> Changes in v2: >> - eliminate more CPUState in user data >> - remove unnecessary user data passing >> - fix target-s390x/kvm.c and target-s390x/misc_helper.c >> >> --- >> cpus.c | 15 ++++--- >> hw/i386/kvm/apic.c | 3 +- >> hw/i386/kvmvapic.c | 6 +-- >> hw/ppc/ppce500_spin.c | 31 +++++---------- >> hw/ppc/spapr.c | 6 +-- >> hw/ppc/spapr_hcall.c | 17 ++++---- >> include/qom/cpu.h | 8 ++-- >> kvm-all.c | 21 ++++------ >> target-i386/helper.c | 19 ++++----- >> target-i386/kvm.c | 6 +-- >> target-s390x/cpu.c | 4 +- >> target-s390x/cpu.h | 7 +--- >> target-s390x/kvm.c | 98 +++++++++++++++++++++++----------------------- >> target-s390x/misc_helper.c | 4 +- >> 14 files changed, 108 insertions(+), 137 deletions(-) > s390 parts look ok. Can this be considered as "Acked-by" or not exactly? Thanks, Sergey