* [Qemu-devel] [PATCH] target-arm: Fix unreachable code in gicv3_class_name()
@ 2016-07-11 18:09 Peter Maydell
2016-07-12 1:23 ` Shannon Zhao
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2016-07-11 18:09 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: patches
Coverity complains that the exit() in gicv3_class_name()
can be unreachable, because if TARGET_AARCH64 is defined
then all code paths return before reaching it. Move the
exit() up to the error_report() that it belongs with.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/machine.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target-arm/machine.c b/target-arm/machine.c
index 2dbeb82..7a6ca31 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -340,10 +340,9 @@ const char *gicv3_class_name(void)
#else
error_report("KVM GICv3 acceleration is not supported on this "
"platform");
+ exit(1);
#endif
} else {
return "arm-gicv3";
}
-
- exit(1);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: Fix unreachable code in gicv3_class_name()
2016-07-11 18:09 [Qemu-devel] [PATCH] target-arm: Fix unreachable code in gicv3_class_name() Peter Maydell
@ 2016-07-12 1:23 ` Shannon Zhao
0 siblings, 0 replies; 2+ messages in thread
From: Shannon Zhao @ 2016-07-12 1:23 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel; +Cc: patches
On 2016/7/12 2:09, Peter Maydell wrote:
> Coverity complains that the exit() in gicv3_class_name()
> can be unreachable, because if TARGET_AARCH64 is defined
> then all code paths return before reaching it. Move the
> exit() up to the error_report() that it belongs with.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> target-arm/machine.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target-arm/machine.c b/target-arm/machine.c
> index 2dbeb82..7a6ca31 100644
> --- a/target-arm/machine.c
> +++ b/target-arm/machine.c
> @@ -340,10 +340,9 @@ const char *gicv3_class_name(void)
> #else
> error_report("KVM GICv3 acceleration is not supported on this "
> "platform");
> + exit(1);
> #endif
> } else {
> return "arm-gicv3";
> }
> -
> - exit(1);
> }
>
--
Shannon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-12 1:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-11 18:09 [Qemu-devel] [PATCH] target-arm: Fix unreachable code in gicv3_class_name() Peter Maydell
2016-07-12 1:23 ` Shannon Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).