From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMySn-0006td-Et for qemu-devel@nongnu.org; Tue, 12 Jul 2016 10:15:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMySi-0006qu-9E for qemu-devel@nongnu.org; Tue, 12 Jul 2016 10:15:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMySi-0006qo-13 for qemu-devel@nongnu.org; Tue, 12 Jul 2016 10:15:00 -0400 References: <1467786055-85835-1-git-send-email-imammedo@redhat.com> <1467786055-85835-9-git-send-email-imammedo@redhat.com> From: Eric Blake Message-ID: <5784FB62.9090307@redhat.com> Date: Tue, 12 Jul 2016 08:14:58 -0600 MIME-Version: 1.0 In-Reply-To: <1467786055-85835-9-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kTWBw74waGVIjjiCr5sird2uFFQx6jGsu" Subject: Re: [Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kTWBw74waGVIjjiCr5sird2uFFQx6jGsu From: Eric Blake To: Igor Mammedov , qemu-devel@nongnu.org Cc: pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net Message-ID: <5784FB62.9090307@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback References: <1467786055-85835-1-git-send-email-imammedo@redhat.com> <1467786055-85835-9-git-send-email-imammedo@redhat.com> In-Reply-To: <1467786055-85835-9-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/06/2016 12:20 AM, Igor Mammedov wrote: > it returns a list of present/possible to hotplug CPU > objects with a list of properties to use with > device_add. >=20 > in PC case returned list would looks like: > -> { "execute": "query-hotpluggable-cpus" } > <- {"return": [ > { > "type": "qemu64-x86_64-cpu", "vcpus-count": 1, > "props": {"core-id": 0, "socket-id": 1, "thread-id": 0} > }, > { > "qom-path": "/machine/unattached/device[0]", > "type": "qemu64-x86_64-cpu", "vcpus-count": 1, > "props": {"core-id": 0, "socket-id": 0, "thread-id": 0} > } > ]} >=20 Matches the schema. > Signed-off-by: Igor Mammedov > --- > v2: > - add -id suffix to socket/core/thread properties to match fixed schem= a > --- > hw/i386/pc.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 15 +++++++++++++++ > 2 files changed, 60 insertions(+) >=20 > +++ b/qmp-commands.hx > @@ -4983,3 +4983,18 @@ Example for pseries machine type started with > { "props": { "core-id": 0 }, "type": "POWER8-spapr-cpu-core", > "vcpus-count": 1, "qom-path": "/machine/unattached/device[0]"} > ]}' > + > +Example for pc machine type started with > +-smp 1,maxcpus=3D2: > + -> { "execute": "query-hotpluggable-cpus" } > + <- {"return": [ > + { > + "type": "qemu64-x86_64-cpu", "vcpus-count": 1, > + "props": {"core-id": 0, "socket-id": 1, "thread-id": 0} > + }, > + { > + "qom-path": "/machine/unattached/device[0]", > + "type": "qemu64-x86_64-cpu", "vcpus-count": 1, > + "props": {"core-id": 0, "socket-id": 0, "thread-id": 0} > + } > + ]} I didn't review the full patch, but the interface change looks okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kTWBw74waGVIjjiCr5sird2uFFQx6jGsu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXhPtiAAoJEKeha0olJ0Nq290H/13HXNrI4Zr8vzQlw8V9/GDe Rsu9EoHeh4F1VvoeNLG9KIqKtPTmiEJgjwsvp/CvmwBOAOQzyJGuKiVVgyp1D36D VzSyv5Z5nYWHDOIF3XYl4TvwaxFbDa3p3m1dcHMIVk9JZZWRjFv+VXr2GrjG2God ss3sPGdSMtQDRJBsdcK7RPHBnVQY8GnJT8bxjIu98/tYzPmFyXxOLnMnUm9I1voW OFmJqa/0QVSAL3vOSn4uI5gH4c4cdZBeNf/bhagxob8a1Ohpz5Jk8fQCRnH+lo8r x3DBs/f80VGWl3m+00vEdN5GVpF3IZuk3kOxFgOS0lT6vhBwP5Wxl7fea7QW8QI= =5Mw+ -----END PGP SIGNATURE----- --kTWBw74waGVIjjiCr5sird2uFFQx6jGsu--