From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNJBV-0001bS-I4 for qemu-devel@nongnu.org; Wed, 13 Jul 2016 08:22:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNJBR-0005bV-6f for qemu-devel@nongnu.org; Wed, 13 Jul 2016 08:22:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNJBQ-0005bE-Tz for qemu-devel@nongnu.org; Wed, 13 Jul 2016 08:22:33 -0400 References: <20160713022334.GB16038@ad.usersys.redhat.com> <1468396629-26094-1-git-send-email-roman.penyaev@profitbricks.com> From: Eric Blake Message-ID: <57863286.9080009@redhat.com> Date: Wed, 13 Jul 2016 06:22:30 -0600 MIME-Version: 1.0 In-Reply-To: <1468396629-26094-1-git-send-email-roman.penyaev@profitbricks.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CSU0q93oXgehvodt3qIeflOeE3eXj0lFQ" Subject: Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Pen Cc: Paolo Bonzini , Fam Zheng , Stefan Hajnoczi , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CSU0q93oXgehvodt3qIeflOeE3eXj0lFQ From: Eric Blake To: Roman Pen Cc: Paolo Bonzini , Fam Zheng , Stefan Hajnoczi , qemu-devel@nongnu.org Message-ID: <57863286.9080009@redhat.com> Subject: Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS References: <20160713022334.GB16038@ad.usersys.redhat.com> <1468396629-26094-1-git-send-email-roman.penyaev@profitbricks.com> In-Reply-To: <1468396629-26094-1-git-send-email-roman.penyaev@profitbricks.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/13/2016 01:57 AM, Roman Pen wrote: > v1..v2: >=20 > o comment tweaks. > o fix QEMU coding style. The above comments should be delayed... >=20 > Invoking io_setup(MAX_EVENTS) we ask kernel to create ring buffer for u= s > with specified number of events. But kernel ring buffer allocation log= ic > is a bit tricky (ring buffer is page size aligned + some percpu allocat= ion > are required) so eventually more than requested events number is alloca= ted. >=20 =2E.. > Signed-off-by: Roman Pen > Reviewed-by: Fam Zheng > Cc: Stefan Hajnoczi > Cc: Paolo Bonzini > Cc: qemu-devel@nongnu.org > --- =2E..until here, after the --- separator. They are useful to reviewers, but won't make much sense a year from now in qemu.git (when we don't care what other versions were on list, only the version that got committe= d). Also, if you use 'git send-email -v2' (or 'git format-patch -v2'), your subject line will resemble most other versioned patches (which use [PATCH v2] rather than [PATCH V2]). We also recommend that v2 patches be sent as top-level threads, rather than in-reply to v1. More submission hints at http://wiki.qemu.org/Contribute/SubmitAPatch --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CSU0q93oXgehvodt3qIeflOeE3eXj0lFQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXhjKGAAoJEKeha0olJ0NqgIgH/0zDMcoeuiCZokN6RrQnzeFx gUUY6C1Y7wypQIWPHq4f++VWc2a5c+l3MLJX5VXTXD4fOl0B9CgR5zEPViqsChFe AKX14QizXAkbg7Bls148mg3JioyU+MHMsiSK+6ypoNB2FUk5gzGF07v273U22P02 pz+g9gns+X++kaW0QNVbqWkojUxIa3c3Ulv4H3T7r8BzCD4afPB3yyBeuh0sqEMG w9SnGiSIT6TxiqrQQgt1Myc9DZNE9xREU3VAgYnZaP6ym0eAVxebxx21P7S79MUD PBaEytcybPrJCu+H1VeND7Z3T37L6QaNZlliuBgM/Lwh7kq6jKQOdiHRaJ8MhHU= =N9an -----END PGP SIGNATURE----- --CSU0q93oXgehvodt3qIeflOeE3eXj0lFQ--