From: Juergen Gross <jgross@suse.com>
To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com
Cc: anthony.perard@citrix.com, sstabellini@kernel.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: remove xenstore watches of backends when terminating qemu
Date: Thu, 14 Jul 2016 11:58:45 +0200 [thread overview]
Message-ID: <57876255.6040407@suse.com> (raw)
In-Reply-To: <1468413065-10299-1-git-send-email-jgross@suse.com>
On 13/07/16 14:31, Juergen Gross wrote:
> Xenstore watches of the /local/domain/<dom>/backend/<type> directories
> are never removed. This can lead to a memory leak in xenstored,
> especially when xenstored is running in another domain (this will be
> the case either for a system with xenstore-stubdom, or with driver
> domains running qemu-based backends).
>
> Avoid this problem by calling xs_unwatch() for these directories when
> terminating qemu.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Please ignore this patch. It is not needed. The issue in xenstored is
_not_ due to not removed watches, but due to non freed memory after
sending a watch event.
Juergen
prev parent reply other threads:[~2016-07-14 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 12:31 [Qemu-devel] [PATCH] xen: remove xenstore watches of backends when terminating qemu Juergen Gross
2016-07-14 9:58 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57876255.6040407@suse.com \
--to=jgross@suse.com \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).