From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNftX-0001Lr-Rs for qemu-devel@nongnu.org; Thu, 14 Jul 2016 08:37:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNftV-0004CZ-PK for qemu-devel@nongnu.org; Thu, 14 Jul 2016 08:37:34 -0400 References: <1467635306-31875-1-git-send-email-den@openvz.org> <1467635306-31875-12-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <57878784.2090806@redhat.com> Date: Thu, 14 Jul 2016 06:37:24 -0600 MIME-Version: 1.0 In-Reply-To: <1467635306-31875-12-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hXA9v3Q31Erfb2vg0qIINdSeHm1A2S9Tx" Subject: Re: [Qemu-devel] [PATCH v5 11/15] block: simplify blockdev-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hXA9v3Q31Erfb2vg0qIINdSeHm1A2S9Tx From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf Message-ID: <57878784.2090806@redhat.com> Subject: Re: [PATCH v5 11/15] block: simplify blockdev-backup References: <1467635306-31875-1-git-send-email-den@openvz.org> <1467635306-31875-12-git-send-email-den@openvz.org> In-Reply-To: <1467635306-31875-12-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/04/2016 06:28 AM, Denis V. Lunev wrote: > From: Pavel Butsykin >=20 > Now that we can support boxed commands, use it to greatly reduce the > number of parameters (and likelihood of getting out of sync) when > adjusting blockdev-backup parameters. >=20 > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > blockdev.c | 65 +++++++++++++++-----------------------------= -------- > qapi/block-core.json | 6 ++++- > 2 files changed, 24 insertions(+), 47 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1088,9 +1088,13 @@ > # > # For the arguments, see the documentation of BlockdevBackup. > # > +# Returns: nothing on success > +# If @device is not a valid block device, DeviceNotFound > +# > # Since 2.3 > ## > -{ 'command': 'blockdev-backup', 'data': 'BlockdevBackup' } > +{ 'command': 'blockdev-backup', 'box': true, > + 'data': 'BlockdevBackup' } Will need a trivial rebase; my pending qapi v9 patches renamed the new parameter 'boxed' instead of 'box'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hXA9v3Q31Erfb2vg0qIINdSeHm1A2S9Tx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh4eEAAoJEKeha0olJ0NqCqcH/1hEIrUOP8Av1Utj2pKnuo5/ qiCfti/U5IIWzFD1LF38GuOPoJpqMypZDtmCoMLARCBL4+zf24aJEOqTWeBH17G0 ZzgauxnmdInAL1CKz5GvH2DjJNE1PDc39kaxy0Dwhk7lI27vcWWv9hbqT9hw2ntk wuRSQn/+wi6n4oKEJ+lSjUzZ9hZ1SBEIvxEzIGfcCXvIyzkxYNhrPPRQZfoFbsmC Kh2Zm680doidDB44nnUW6NwjeI+1taMjgItmzYR9OvROiM2+882QqOZGweHR/Xtq W/pmzL02qeDGUG+fs1+a/O6BEhyi0gQ2sHugTHoemyGgY8GqcSjOxI57DNnPosI= =iKdC -----END PGP SIGNATURE----- --hXA9v3Q31Erfb2vg0qIINdSeHm1A2S9Tx--