From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNhK6-0007gE-Vy for qemu-devel@nongnu.org; Thu, 14 Jul 2016 10:09:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNhK5-0007Wn-RP for qemu-devel@nongnu.org; Thu, 14 Jul 2016 10:09:06 -0400 References: <1468501843-14927-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <57879CFA.9040700@redhat.com> Date: Thu, 14 Jul 2016 08:08:58 -0600 MIME-Version: 1.0 In-Reply-To: <1468501843-14927-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bR1Q8qTSPQbWQqxgXnJdCs50fXcqBerJ9" Subject: Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, famz@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bR1Q8qTSPQbWQqxgXnJdCs50fXcqBerJ9 From: Eric Blake To: Cao jin , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, famz@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com Message-ID: <57879CFA.9040700@redhat.com> Subject: Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE References: <1468501843-14927-1-git-send-email-caoj.fnst@cn.fujitsu.com> In-Reply-To: <1468501843-14927-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:10 AM, Cao jin wrote: > replace tab with spaces >=20 > Signed-off-by: Cao jin > --- > async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Whitespace-only changes are best done as part of a series that is already touching nearby code for other reasons (depending on the size of the whitespace changes and on the rest of your patch, it may be okay to squash the whitespace change in place, or better to split into separate patches to make review of both patches easier). Otherwise, it just makes 'git blame' output dirtier. >=20 > diff --git a/async.c b/async.c > index 1f9754b..8589017 100644 > --- a/async.c > +++ b/async.c > @@ -217,7 +217,7 @@ aio_ctx_check(GSource *source) > for (bh =3D ctx->first_bh; bh; bh =3D bh->next) { > if (!bh->deleted && bh->scheduled) { > return true; > - } > + } Nothing wrong with the patch itself, and I won't oppose it going in, but it's generally not worth the effort if nothing else in this file needs fixing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bR1Q8qTSPQbWQqxgXnJdCs50fXcqBerJ9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh5z6AAoJEKeha0olJ0NqChUH/iRhnQmYpeDLiiBPJmx3BRYF /ZG1T/fWK85mRLocjm0gsB4/GIOGNhe14lNtmz9/Qp0kRs37+P88gfkw1cbJGBKA D2rgDhm0tf+0eNcJSH4yeUpUjLNcQAFIQTBVt3+ntBWlHHr2A5XIWUdwhfxlUhP7 OH278VVu0YsfMp6nrL1MIcpuky8LpGuQK35STH9vTNcN7eLYtHioAwK542X387h1 UcSBC+XH+GjC0p+dZ99oD8Se/uibdJsc4I0zd4/Bz57oTOzZnBggzFMSYbY0Gb2O 53zPePBroYzvgWo7lNQIqya0c00w5+oEw/y/f1se4DeLBkv97IPj5MEENdLaD68= =5S9L -----END PGP SIGNATURE----- --bR1Q8qTSPQbWQqxgXnJdCs50fXcqBerJ9--