From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNiLt-0005rk-Ve for qemu-devel@nongnu.org; Thu, 14 Jul 2016 11:15:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNiLr-0007bM-U8 for qemu-devel@nongnu.org; Thu, 14 Jul 2016 11:15:00 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-3-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787AC6C.5010402@redhat.com> Date: Thu, 14 Jul 2016 09:14:52 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hsn6Jb8QUQalXjiFcKmdgEXiw1u4FlocU" Subject: Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hsn6Jb8QUQalXjiFcKmdgEXiw1u4FlocU From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <5787AC6C.5010402@redhat.com> Subject: Re: [PATCH v4 02/11] block: Accept node-name for block-commit References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-commit to accept a node-name without lifting the restriction that= > we're operating at a root node. >=20 > As libvirt makes use of the DeviceNotFound error class, we must add > explicit code to retain this behaviour because qmp_get_root_bs() only > returns GenericErrors. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 23 +++++++++++------------ > qapi/block-core.json | 2 +- > qmp-commands.hx | 2 +- > 3 files changed, 13 insertions(+), 14 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Hsn6Jb8QUQalXjiFcKmdgEXiw1u4FlocU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh6xsAAoJEKeha0olJ0NqIr0H/jD9xIXLaZwTMQmXcmoJJTgj 8+XoExeCQTlExEPAoY/blkm52LY5ECHkLtNZ5ogtN8xHKVduRmFNeMm+g3yzOhj5 gp3Xw7nQ2Zrw9jDlCY0DJ1DdBr/FiMUkatRdz09z5VNZi04SdzQYXBfKI9JyxftY wpUzxfnuiBdoMh2p8HwaR9sHQf47N7nacqxtZJbCgCBZ9lWxWG/vHPr9YvJmlIdf 29LbeAGvL/5lf749PxbwVqIyCs+zKLIWt0dd+KySWxNGh8pX/LzPAKy8HAhJE8Xi edxeVg01VUZcF0XTFxRLJi9VtA3JzwedhLcQhcnw1uX9PNED4CWkwb5oERZyI90= =AJso -----END PGP SIGNATURE----- --Hsn6Jb8QUQalXjiFcKmdgEXiw1u4FlocU--