From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjB1-00023p-3W for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:07:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNjAy-0005t7-To for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:07:49 -0400 References: <1468499383-17840-1-git-send-email-den@openvz.org> <1468499383-17840-7-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5787B8CC.8050703@redhat.com> Date: Thu, 14 Jul 2016 10:07:40 -0600 MIME-Version: 1.0 In-Reply-To: <1468499383-17840-7-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="keKhCRv1uKVg9k4dibaEbm6WtA1LVSgi8" Subject: Re: [Qemu-devel] [PATCH v6 6/6] tests: changed block job ready event generation order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Evgeny Yakovlev , Max Reitz , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --keKhCRv1uKVg9k4dibaEbm6WtA1LVSgi8 From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Evgeny Yakovlev , Max Reitz , Stefan Hajnoczi , John Snow Message-ID: <5787B8CC.8050703@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 6/6] tests: changed block job ready event generation order References: <1468499383-17840-1-git-send-email-den@openvz.org> <1468499383-17840-7-git-send-email-den@openvz.org> In-Reply-To: <1468499383-17840-7-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 06:29 AM, Denis V. Lunev wrote: > From: Evgeny Yakovlev >=20 > Due to skipped flushes on bdrv_co_flush BLOCK_JOB_READY events > for driver-mirror and active block-commit commands now arrives faster, > before QMP send successfully returns to caller. >=20 > This change expects for block job ready event to arrive before > QMP send successfully returns in block tests 141 144 >=20 > Signed-off-by: Evgeny Yakovlev > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Max Reitz > CC: Stefan Hajnoczi > CC: Fam Zheng > CC: John Snow > --- > tests/qemu-iotests/141.out | 4 ++-- > tests/qemu-iotests/144.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Same comment as in 5/6: if the testsuite broke as a result of 4/6, then this should be squashed in to that patch so that the end result of your series never lands on a bisection point where the testsuite is broken. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --keKhCRv1uKVg9k4dibaEbm6WtA1LVSgi8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh7jMAAoJEKeha0olJ0NqeiEH/0pzj5Zeqo3WYo7fl8maibxY d6z+f5hDrZhVa778OdouztEYAHrfJJYXalSPQka8IH7zcfYDob9ztGNuCdXC6uvL WRoNByX00ds0osjH/q1Q1CTziBgC0VJDIIX90v3l+aI7GMjHjPzxMN+gbrArF8hH /VSitjQXJqrDmkR17bd0C9VWMe8PAVXxIjWqjdjfo7YJ1VAGNCL+LRprimtu/BPH U7mc7ySnqBmFlayyMPPrP7VMZXG5XNqShg1hfPPFUXiIX2P+hlNNnU/v3c0C1bbp HsvbS8jCkxBx9ixj2OmcPwI6fWPJl1+recDJUvyLRKaFmC0pDLNDO8VJfqYgcL0= =Frgu -----END PGP SIGNATURE----- --keKhCRv1uKVg9k4dibaEbm6WtA1LVSgi8--