From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjMN-00079g-W3 for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNjMM-0000Dj-Qq for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:19:35 -0400 References: <1468503209-19498-1-git-send-email-den@openvz.org> <1468503209-19498-5-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5787BB8E.5050003@redhat.com> Date: Thu, 14 Jul 2016 10:19:26 -0600 MIME-Version: 1.0 In-Reply-To: <1468503209-19498-5-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HpmEoNhvbCcq1fA3pqka3G7ItbceCTvUD" Subject: Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Kevin Wolf , Max Reitz , Jeff Cody This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HpmEoNhvbCcq1fA3pqka3G7ItbceCTvUD From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Kevin Wolf , Max Reitz , Jeff Cody Message-ID: <5787BB8E.5050003@redhat.com> Subject: Re: [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run References: <1468503209-19498-1-git-send-email-den@openvz.org> <1468503209-19498-5-git-send-email-den@openvz.org> In-Reply-To: <1468503209-19498-5-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:33 AM, Denis V. Lunev wrote: > The code inside the helper will be extended in the next patch. mirror_r= un > itself is overbloated at the moment. >=20 > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake I did NOT give R-b on v2 3/7. In particular, this patch has semantic changes that I requested on v2, and so you want to make sure I re-review it (I often skip re-reviewing a patch that has my R-b listed, on the grounds that I'm trusting your judgment that it hasn't substantially changed since my last time through it; but here, you have changed it since last time). > Reviewed-by: Fam Zheng > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Max Reitz > CC: Jeff Cody > CC: Eric Blake > --- > block/mirror.c | 70 ++++++++++++++++++++++++++++++++++----------------= -------- > 1 file changed, 41 insertions(+), 29 deletions(-) That said, I've looked through the changes (the rebase on top of moving last_pause_ns to being a member of s, so that a single timestamp is shared across both functions), and can now safely state: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HpmEoNhvbCcq1fA3pqka3G7ItbceCTvUD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh7uOAAoJEKeha0olJ0Nqk3wIAJt5T2uuagr9rUUqsMq8XWDu 1AJ6nV4wl1tg6bhISH8RbGfoqx8vy5CYLZWFBDOHsmDXmBa+hW6DcXQtxFKsdEet onPikoeQWor7yMkUSc2fLu+Os4kp0AYRdRtQoNbRARaQAsqatMWmjvB19AMd6zTI WHKjJc1NrEEJ8U53Cf73DDgG3aueadN3QPf6wcWikgnBBBmBzHcbstMCq6I653w+ aI5jfOBRKP6J0qDE1mxqkwXST1tXcQEBAgr9wCVx+gWxRUEmLCFfj53DdelnKi0I QHJ66JPj2gDX6GFsq/NRvSVzynKAQPDzgwTprYt6YX1Yv+O3GaSx2tqGFE8kS2s= =SwT1 -----END PGP SIGNATURE----- --HpmEoNhvbCcq1fA3pqka3G7ItbceCTvUD--