From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNmCB-00004v-Mk for qemu-devel@nongnu.org; Thu, 14 Jul 2016 15:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNmC7-0006GS-EV for qemu-devel@nongnu.org; Thu, 14 Jul 2016 15:21:14 -0400 References: <1468503209-19498-1-git-send-email-den@openvz.org> <1468503209-19498-5-git-send-email-den@openvz.org> <5787BB8E.5050003@redhat.com> From: "Denis V. Lunev" Message-ID: <5787C264.9010804@openvz.org> Date: Thu, 14 Jul 2016 19:48:36 +0300 MIME-Version: 1.0 In-Reply-To: <5787BB8E.5050003@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Kevin Wolf , Max Reitz , Jeff Cody On 07/14/2016 07:19 PM, Eric Blake wrote: > On 07/14/2016 07:33 AM, Denis V. Lunev wrote: >> The code inside the helper will be extended in the next patch. mirror_run >> itself is overbloated at the moment. >> >> Signed-off-by: Denis V. Lunev >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> Reviewed-by: Eric Blake > I did NOT give R-b on v2 3/7. In particular, this patch has semantic > changes that I requested on v2, and so you want to make sure I re-review > it (I often skip re-reviewing a patch that has my R-b listed, on the > grounds that I'm trusting your judgment that it hasn't substantially > changed since my last time through it; but here, you have changed it > since last time). > sorry :(