From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNo2u-0003PU-OB for qemu-devel@nongnu.org; Thu, 14 Jul 2016 17:19:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNo2t-0005NF-2U for qemu-devel@nongnu.org; Thu, 14 Jul 2016 17:19:48 -0400 References: <1468524731-2306-1-git-send-email-vaibhav@digitalocean.com> <5787F5E5.1040209@redhat.com> From: Eric Blake Message-ID: <578801EA.3020505@redhat.com> Date: Thu, 14 Jul 2016 15:19:38 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="McBhiQbDN6N3ckxmkj2he0HgjGh5lfQQG" Subject: Re: [Qemu-devel] [PATCH v2] rbd: reload ceph config for block device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vaibhav Bhembre Cc: qemu-devel@nongnu.org, Josh Durgin , Jeff Cody , Kevin Wolf , Max Reitz , Luiz Capitulino , Markus Armbruster , qemu block This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --McBhiQbDN6N3ckxmkj2he0HgjGh5lfQQG From: Eric Blake To: Vaibhav Bhembre Cc: qemu-devel@nongnu.org, Josh Durgin , Jeff Cody , Kevin Wolf , Max Reitz , Luiz Capitulino , Markus Armbruster , qemu block Message-ID: <578801EA.3020505@redhat.com> Subject: Re: [PATCH v2] rbd: reload ceph config for block device References: <1468524731-2306-1-git-send-email-vaibhav@digitalocean.com> <5787F5E5.1040209@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 02:53 PM, Vaibhav Bhembre wrote: > Thanks Eric! meta-comment - your mailer's default quoting behavior makes it very hard to read your replies. Observe: >=20 > On Thu, Jul 14, 2016 at 4:28 PM, Eric Blake wrote: >=20 >> On 07/14/2016 01:32 PM, Vaibhav Bhembre wrote: >>> This patch adds ability to reload ceph configuration for an attached = RBD >>> block device. This is necessary for the cases where rebooting a VM an= d/or >>> detaching-reattaching a RBD drive is not an easy option. >> >> Probably worth including qemu-block@nongnu.org if you resend this. I'v= e >> added them in cc now, per the output of: >> scripts/get_maintainer.pl -f block/rbd >> >>> >>> The reload mechanism relies on the bdrv_reopen_* calls to provide a >> transactional >>> guarantee (using 2PC) for pulling in new configuration parameters. In= >> the _prepare Your mailer wrapped your lines but used inconsistent prefix when doing so, which makes attribution of the lines difficult (some start with '>>>', which traces to you, some start with '>>' which traces to me) (of course, this is after my mailer has added yet another round of > prefixing, but at least I know my mailer [Thunderbird] has sane quoting behavior for the most part). =2E.. >>> +# Since: 2.7 >> >> v1 was posted June 17, before soft freeze on June 28, so this may stil= l >> make hard freeze if someone picks it up before hard freeze on July 19.= >> But we're getting close. >> >> =E2=80=8BHoping so! =E2=80=8B >=20 Here, both my text ("But we're getting close") and your text ("Hoping so!") are prefixed with the same '>>' prefix, which makes it sound like I wrote your reply. >> We may want to rebase this on top of Kevin's series that adds >> qmp_get_root_bs() >> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg03086.html >> >> =E2=80=8BThis is exactly what I need. Should I wait for other reviews = before > making this change or should I push it right-away? and here, half your paragraph is attributed to me (prefix of '>>') while only the second half is attributed to you (prefix of '>'). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --McBhiQbDN6N3ckxmkj2he0HgjGh5lfQQG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXiAHqAAoJEKeha0olJ0NqlksIAIVRcJY2rhuohJpcaG5LgYWm JKh5BxsBZitdEQhkJmdiLHKGUSUergTEybKut3cCYOjVROe4LFzbBRCQp/LTJbYn GkwpA2KlBxEZxwN/CaZjd9oFLUkXT/3nDqOIm412D0zkvoQqkKYW/M5fOu2tNVFW w/QCAt1o2FncPV67gflG/TwQ9dNo07tkuB6vvbaplLcioGkZ9oIFHctLJt2mscsy vUxspN52avWbtR7QGQ3ulEsl+KZTP5YSTQcZXMSaVjX/H0oieHa28RO9RzjXSOUf BzVSjwu5kGbUsHyj0Er0BPAWmH9xDsnsVZrv1sKxdUb7kpNyrz+N1x4oxEmeZsM= =x61F -----END PGP SIGNATURE----- --McBhiQbDN6N3ckxmkj2he0HgjGh5lfQQG--