From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, famz@redhat.com, qemu-block@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE
Date: Fri, 15 Jul 2016 09:48:50 +0800 [thread overview]
Message-ID: <57884102.3050905@cn.fujitsu.com> (raw)
In-Reply-To: <57879CFA.9040700@redhat.com>
On 07/14/2016 10:08 PM, Eric Blake wrote:
> On 07/14/2016 07:10 AM, Cao jin wrote:
>> replace tab with spaces
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>> async.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Whitespace-only changes are best done as part of a series that is
> already touching nearby code for other reasons (depending on the size of
> the whitespace changes and on the rest of your patch, it may be okay to
> squash the whitespace change in place, or better to split into separate
> patches to make review of both patches easier). Otherwise, it just
> makes 'git blame' output dirtier.
I see.
Since async.c & aio-posix.c are belong to the same maintaiers, so, Fam &
Stefan, is it ok to squash this into that "remove useless parameter"
patch? If not, we can just forget this one.
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-07-15 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:10 [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE Cao jin
2016-07-14 14:08 ` Eric Blake
2016-07-15 1:48 ` Cao jin [this message]
2016-07-15 10:40 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-07-15 11:04 ` Cao jin
2016-07-15 10:42 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57884102.3050905@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).