From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNs8h-0005mH-UL for qemu-devel@nongnu.org; Thu, 14 Jul 2016 21:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNs8f-0000V8-Us for qemu-devel@nongnu.org; Thu, 14 Jul 2016 21:42:02 -0400 References: <1468501843-14927-1-git-send-email-caoj.fnst@cn.fujitsu.com> <57879CFA.9040700@redhat.com> From: Cao jin Message-ID: <57884102.3050905@cn.fujitsu.com> Date: Fri, 15 Jul 2016 09:48:50 +0800 MIME-Version: 1.0 In-Reply-To: <57879CFA.9040700@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, famz@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com On 07/14/2016 10:08 PM, Eric Blake wrote: > On 07/14/2016 07:10 AM, Cao jin wrote: >> replace tab with spaces >> >> Signed-off-by: Cao jin >> --- >> async.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Whitespace-only changes are best done as part of a series that is > already touching nearby code for other reasons (depending on the size of > the whitespace changes and on the rest of your patch, it may be okay to > squash the whitespace change in place, or better to split into separate > patches to make review of both patches easier). Otherwise, it just > makes 'git blame' output dirtier. I see. Since async.c & aio-posix.c are belong to the same maintaiers, so, Fam & Stefan, is it ok to squash this into that "remove useless parameter" patch? If not, we can just forget this one. -- Yours Sincerely, Cao jin