From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
mtosatti@redhat.com, mst@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, dan.j.williams@intel.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support
Date: Fri, 15 Jul 2016 15:49:12 +0800 [thread overview]
Message-ID: <57889578.10504@linux.intel.com> (raw)
In-Reply-To: <20160714121755.GM15476@stefanha-x1.localdomain>
On 07/14/2016 08:17 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 11, 2016 at 09:45:17PM +0800, Xiao Guangrong wrote:
>> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
>> index 73fa62d..d1c2e92 100644
>> --- a/hw/acpi/memory_hotplug.c
>> +++ b/hw/acpi/memory_hotplug.c
>> @@ -239,11 +239,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st,
>> DeviceState *dev, Error **errp)
>> {
>> MemStatus *mdev;
>> - DeviceClass *dc = DEVICE_GET_CLASS(dev);
>> -
>> - if (!dc->hotpluggable) {
>> - return;
>> - }
>>
>> mdev = acpi_memory_slot_status(mem_st, dev, errp);
>> if (!mdev) {
>
> Did you mean to include this hunk in the patch? Looks like something
> left over from debugging/prototyping.
>
As all memory devices, both pc-dimm and nvdimm, have supported hotplug now, i
think this chunk can be removed.
In fact, this check was introduced by nvdimm. :)
next prev parent reply other threads:[~2016-07-15 7:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 13:45 [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 2/8] nvdimm acpi: prebuild nvdimm devices for available slots Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 3/8] nvdimm acpi: introduce _FIT Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 4/8] nvdimm acpi: implement Read FIT function Xiao Guangrong
2016-07-14 12:17 ` Stefan Hajnoczi
2016-07-15 7:43 ` Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 5/8] pc-dimm: introduce prepare_unplug() callback Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 6/8] pc: memhp: do not export nvdimm's memory via _CRS Xiao Guangrong
2016-07-11 13:45 ` [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support Xiao Guangrong
2016-07-14 12:17 ` Stefan Hajnoczi
2016-07-15 7:49 ` Xiao Guangrong [this message]
2016-07-15 9:56 ` Stefan Hajnoczi
2016-07-11 13:45 ` [Qemu-devel] [PATCH 8/8] nvdimm docs: add nvdimm Read FIT function Xiao Guangrong
2016-07-11 14:12 ` [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support Igor Mammedov
2016-07-11 22:49 ` Xiao Guangrong
2016-07-14 12:17 ` Stefan Hajnoczi
2016-07-15 7:55 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57889578.10504@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).