From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP19h-0006Sd-AB for qemu-devel@nongnu.org; Mon, 18 Jul 2016 01:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP19b-0006OM-DL for qemu-devel@nongnu.org; Mon, 18 Jul 2016 01:31:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP19b-0006OB-7V for qemu-devel@nongnu.org; Mon, 18 Jul 2016 01:31:43 -0400 References: <1466592545-9105-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <20160708014823.GA13961@ad.usersys.redhat.com> <20160708085401.GA3205@redhat.com> <23246597-319a-d568-6fcc-738f5eb1341a@redhat.com> <57830099.5030108@cn.fujitsu.com> <578C370B.8020302@cn.fujitsu.com> From: Jason Wang Message-ID: <578C69B7.2010707@redhat.com> Date: Mon, 18 Jul 2016 13:31:35 +0800 MIME-Version: 1.0 In-Reply-To: <578C370B.8020302@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V2] qemu-char: Fix context for g_source_attach() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , Paolo Bonzini , "Daniel P. Berrange" , Fam Zheng Cc: "eddie . dong" , qemu devel , Li Zhijian On 2016=E5=B9=B407=E6=9C=8818=E6=97=A5 09:55, Zhang Chen wrote: > Hi~ All~~ > > Can you give me some feedback for this patch? > > We need more comments~~ > > COLO project depend on this patch to work. > > Because this patch colo-compare can make handler of=20 > qemu_chr_add_handlers() > > run in compare thread, reduce workload of main_loop in network busy=20 > situation. > > This idea from Jason. > > > Thanks > Zhang Chen I think you can put this patch in the series of COLO comparing thread=20 which shows its using. And then you can ask acked-by or reviewed-by from=20 other maintainers. Thanks