From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP9zR-00028u-TZ for qemu-devel@nongnu.org; Mon, 18 Jul 2016 10:57:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP9zO-0004Zs-Lv for qemu-devel@nongnu.org; Mon, 18 Jul 2016 10:57:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP9zK-0004Yk-3d for qemu-devel@nongnu.org; Mon, 18 Jul 2016 10:57:46 -0400 References: From: Eric Blake Message-ID: <578CEE62.7010700@redhat.com> Date: Mon, 18 Jul 2016 08:57:38 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS" Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Quan Xu , rea , Stefano Stabellini , "anthony.perard" Cc: qemu-devel , stefanb , xen-devel , dgdegra , "wei.liu2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS From: Eric Blake To: Quan Xu , rea , Stefano Stabellini , "anthony.perard" Cc: qemu-devel , stefanb , xen-devel , dgdegra , "wei.liu2" Message-ID: <578CEE62.7010700@redhat.com> Subject: Re: [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/17/2016 01:41 AM, Quan Xu wrote: >=20 > [Quan:]: comment starts with [Quan:] >=20 This line doesn't belong in a commit message; it's fine to put it after the --- separator though, if it aids mailing list reviewers. >=20 > The purpose of the new file is to store generic functions shared by fro= ntendand backends such as xenstore operations, xendevs. >=20 s/frontendand/front end and/ Please wrap your commit message lines. Since 'git log' displays logs with indentation, wrapping around 72 characters is ideal. > Signed-off-by: Quan Xu > Signed-off-by: Emil Condrea These are not valid S-o-b, therefore this patch cannot be applied as-is. > -int xenstore_read_int(const char *base, const char *node, int *ival) > -{ > - char *val; > - int rc =3D -1; > - > - val =3D xenstore_read_str(base, node); > [Quan:]: IMO, it is better to initialize val when declares. the same = comment for the other 'val' > - if (val && 1 =3D=3D sscanf(val, "%d", ival)) { This is not a valid patch. Are you replying to a patch that someone else posted? If so, your quoting style is VERY difficult to read. Please consider using a leading > before every line that you are quoting (rather than pasting it verbatim as if you had written it), and include a blank line both before and after every line that you insert, to call visual attention to what is your reply vs. what you are quoting. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjO5jAAoJEKeha0olJ0NqhYsH/2z6L40TRIXCiRTjZmlSFVQO amMzzFgaSkyJrj8HabzBYVSWUvyukhKJoBPslh/Gsjx+SkOlc0EXIKgKGVB6BDeK oMXJZse1uYVYcLkhP1hgPR4NLXSubjaCs4lhvBTN/gWmAxx0h7T63R6s9F3scsYT wNL6XZSjMhiZnm585ce0Z9ZBnkZVkvS5M87ndp5Xzf7s1jeH9YHNAnGHniMrCs3A epMEXczXfDInN9cgbZPZPnqpTWvfHi8PsJfTZyuIuDK7UW+g9PJMEzhJa8zgFhgr YwsajqqzlivG7KnR1vMI/i7AI/8ZpyjKvOmkozf57+nOMOQHOC2ViTQrMvsGNTc= =gNXe -----END PGP SIGNATURE----- --NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS--