From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPZSf-0005Oz-5Y for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:09:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPZSa-0005L8-6L for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:09:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPZSZ-0005L3-Tu for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:09:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8856A63E34 for ; Tue, 19 Jul 2016 18:09:35 +0000 (UTC) References: <1468947453-5433-1-git-send-email-prasanna.kalever@redhat.com> <1468947453-5433-4-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <578E6CDE.4080808@redhat.com> Date: Tue, 19 Jul 2016 12:09:34 -0600 MIME-Version: 1.0 In-Reply-To: <1468947453-5433-4-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DlI35W18P0Xxnhw2lV97Al8PmJGqNWUq1" Subject: Re: [Qemu-devel] [PATCH v20 3/5] block/gluster: deprecate rdma support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: armbru@redhat.com, kwolf@redhat.com, pkrempa@redhat.com, jcody@redhat.com, rtalur@redhat.com, vbellur@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DlI35W18P0Xxnhw2lV97Al8PmJGqNWUq1 From: Eric Blake To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: armbru@redhat.com, kwolf@redhat.com, pkrempa@redhat.com, jcody@redhat.com, rtalur@redhat.com, vbellur@redhat.com Message-ID: <578E6CDE.4080808@redhat.com> Subject: Re: [PATCH v20 3/5] block/gluster: deprecate rdma support References: <1468947453-5433-1-git-send-email-prasanna.kalever@redhat.com> <1468947453-5433-4-git-send-email-prasanna.kalever@redhat.com> In-Reply-To: <1468947453-5433-4-git-send-email-prasanna.kalever@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 10:57 AM, Prasanna Kumar Kalever wrote: Grammar suggestions, can be squashed in by the maintainer (in addition to what Markus pointed out): > gluster volfile server fetch happens through unix and/or tcp, it doesn'= t > support volfile fetch over rdma, the rdma code may actually mislead, s/rdma, the/rdma. The/ > to make sure things do not break, for now we fallback to tcp when reque= sted s/to make/so to make/ > for rdma with a warning. s/rdma with/rdma, with/ >=20 > If you are wondering how this worked all these days, its the gluster li= bgfapi > code which handles anything other than unix transport as socket/tcp, sa= d but > true. >=20 > Also gluster doesn't support ipv6 addresses, removing the ipv6 related > comments/docs section >=20 > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) >=20 > diff --git a/block/gluster.c b/block/gluster.c > index 40ee852..8a54ad4 100644 > --- a/block/gluster.c > +++ b/block/gluster.c > @@ -12,6 +12,7 @@ > #include "block/block_int.h" > #include "qapi/error.h" > #include "qemu/uri.h" > +#include "qemu/error-report.h" > =20 > #define GLUSTER_OPT_FILENAME "filename" > #define GLUSTER_OPT_DEBUG "debug" > @@ -134,12 +135,10 @@ static int parse_volume_options(GlusterConf *gcon= f, char *path) > * > * 'transport' specifies the transport type used to connect to gluster= > * management daemon (glusterd). Valid transport types are > - * tcp, unix and rdma. If a transport type isn't specified, then tcp > - * type is assumed. > + * tcp, unix. If a transport type isn't specified, then tcp type is as= sumed. s/tcp, unix/tcp or unix/ > * > * 'host' specifies the host where the volume file specification for > - * the given volume resides. This can be either hostname, ipv4 address= > - * or ipv6 address. ipv6 address needs to be within square brackets [ = ]. > + * the given volume resides. This can be either hostname, ipv4 address= =2E s/either hostname, ipv4 address/either a hostname or an ipv4 address/ > @@ -1048,6 +1046,12 @@ static BlockDriver bdrv_gluster_unix =3D { > .create_opts =3D &qemu_gluster_create_opts, > }; > =20 > +/* rdma is deprecated (actually never supported for volfile fetch) > + * lets maintain for the protocol compatibility, to make sure things s/fetch) lets maintain for/fetch). Let's maintain it for/ > + * won't break immediately for now gluster+rdma will fall back to glus= ter+tcp s/immediately for now gluster+rdma/immediately. For now, gluster+rdma/ > + * protocol with Warning s/Warning/a warning/ > + * TODO: remove gluster+rdma interface support > + */ > static BlockDriver bdrv_gluster_rdma =3D { > .format_name =3D "gluster", > .protocol_name =3D "gluster+rdma", >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DlI35W18P0Xxnhw2lV97Al8PmJGqNWUq1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjmzeAAoJEKeha0olJ0Nqr+4H/ApFoasf/mX0byBF+4z5Y8f4 Vd9dd70+L7cJFQBUiEwgdhuO+kin3mE7wUn5yXrKa5eS1J26bLqzfu0w53BSuyII x85PXEJnyKaymMpElv/b56LmWr4fyQpDxeT5df+1plEOlJpail0882nMzxHg3RUP WlpGb/Z/+9OO5JC9Aat3QJQpIGg+b1oQPLWyMUdBKd4b8Bkn/SMIn8kdVK9AeQ/0 EuCephEsjToJ2fMzaq3TiR0uJ5tmwd3/DhfDMSRmOXHhYL5LQB3ocvRGGeExuFjg sXWwef+yk5RvGj2Sew4t+PKDC18e5LRefWElYr7YkuJToMGH6Se96Lzx76Sz3+M= =4run -----END PGP SIGNATURE----- --DlI35W18P0Xxnhw2lV97Al8PmJGqNWUq1--