From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPbua-0003ud-D9 for qemu-devel@nongnu.org; Tue, 19 Jul 2016 16:46:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPbuX-0006xe-Ab for qemu-devel@nongnu.org; Tue, 19 Jul 2016 16:46:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPbuX-0006xa-4f for qemu-devel@nongnu.org; Tue, 19 Jul 2016 16:46:37 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE254C00F0AB for ; Tue, 19 Jul 2016 20:46:36 +0000 (UTC) References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-8-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <578E91AB.7060509@redhat.com> Date: Tue, 19 Jul 2016 14:46:35 -0600 MIME-Version: 1.0 In-Reply-To: <20160719085432.4572-8-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cgBoI4aUOWmxC33E9kw6GJ4xP2TGexa2L" Subject: Re: [Qemu-devel] [PATCH 07/37] tests: fix test-iov leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cgBoI4aUOWmxC33E9kw6GJ4xP2TGexa2L From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Message-ID: <578E91AB.7060509@redhat.com> Subject: Re: [Qemu-devel] [PATCH 07/37] tests: fix test-iov leaks References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-8-marcandre.lureau@redhat.com> In-Reply-To: <20160719085432.4572-8-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 02:54 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Spotted thanks to ASAN. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/test-iov.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/tests/test-iov.c b/tests/test-iov.c > index 46ae25e..a22d71f 100644 > --- a/tests/test-iov.c > +++ b/tests/test-iov.c > @@ -208,6 +208,9 @@ static void test_io(void) > } while(k < j); > } > } > + iov_free(iov, niov); > + g_free(buf); > + g_free(siov); > exit(0); Calling exit() implicitly frees things, but I'm not opposed to the patch.= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cgBoI4aUOWmxC33E9kw6GJ4xP2TGexa2L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjpGrAAoJEKeha0olJ0Nq62YH+gNrJP25T81hbYT/TpztWeNi AgMwsL5+q+3XMlTfZhS2JTUd+2SP59LWsc2z3KFFkx6mU6Q6gH97WhjD8zsMWpTK az87emIVBrxP28fw3cukDt1j7NeHICKvmpKuYiVrPdqA1conn8mGLVxOIGT90CkK KfDc2e0epDV1mdcJLUUYmm/AtTkCHETS44xEU7rkZXIxcw0BxMn8nz9fYRCTRfKl wLe4jbbQAYjH2vxberwSEgIRpBL2AadYaTBzkgEAs8HuHEME787pqzp9gqsv5tLX jxd4yK99LBatM+D5C+etKuuG+zCBdeJLqvcuVFclSWYiL58p9hhAsWjpj82WUxI= =RQ7V -----END PGP SIGNATURE----- --cgBoI4aUOWmxC33E9kw6GJ4xP2TGexa2L--