From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPnNX-00051J-OY for qemu-devel@nongnu.org; Wed, 20 Jul 2016 05:01:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPnNU-0001IU-LU for qemu-devel@nongnu.org; Wed, 20 Jul 2016 05:01:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPnNU-0001IM-Ff for qemu-devel@nongnu.org; Wed, 20 Jul 2016 05:01:16 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E789F63337 for ; Wed, 20 Jul 2016 09:01:14 +0000 (UTC) References: <1468953778-15295-1-git-send-email-marcel@redhat.com> <20160720013838-mutt-send-email-mst@kernel.org> <1469004067.3363.34.camel@redhat.com> From: Marcel Apfelbaum Message-ID: <578F3DD8.8050804@redhat.com> Date: Wed, 20 Jul 2016 12:01:12 +0300 MIME-Version: 1.0 In-Reply-To: <1469004067.3363.34.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 07/20/2016 11:41 AM, Gerd Hoffmann wrote: >>> Notes: >>> - The non PCIe machines behaviour should remain the same. >>> - I hope is OK to make the disable-* properties OnOffAuto. Previous setups >>> using them can be affected, >> >> why? could you explain pls? isn't onoffauto compatible with bit >> properties? > > I have the same question ;) > Hi Gerd, As I explained to Michael, I saw the 'off' value goes from 0 to 2, bu the name remains the same... :) I wasn't sure if is possible to use 0/1 instead of on/off, then we would have a problem. >> Also, I wonder how does this interact with devices that play with >> these flags themselves, like virtio gpu? > > virtio input forces virtio 1.0 only too. > I think they must be changed to set the new property variables instead. > I can do that. I preferred a minimalist approach since we are in "hard-freeze" and I wanted to make the change for 2.7 . >> I guess we could just set VIRTIO_PCI_FLAG_DISABLE_LEGACY, avoid clearing it. > > I think we should simply drop the flags and use bool variables instead. > You mean OnOffAuto new fields, right? We would need a wrapper since "auto" mode is not an actual value. But is doable, of course. > Also while being at it: Should we enable modern by default for all pci > devices? > I am not against it, if Michael approves I'll change that too, even for 2.7 Thanks, Marcel > cheers, > Gerd >