From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, leon.alrae@imgtec.com
Subject: Re: [Qemu-devel] [PATCH] jazz_led: fix bad snprintf
Date: Fri, 5 May 2017 09:22:31 +0200 [thread overview]
Message-ID: <578c614d-741f-bac5-b42a-86e61a6658e4@redhat.com> (raw)
In-Reply-To: <3a1419bd-710a-61f5-bfee-0eb5895a022c@msgid.tls.msk.ru>
On 05/05/2017 08:24, Michael Tokarev wrote:
> 03.05.2017 13:44, Paolo Bonzini wrote:
>> Detected by GCC 7's -Wformat-truncation. snprintf writes at most
>> 2 bytes here including the terminating NUL, so the result is
>> truncated. In addition, the newline at the end is pointless.
>> Fix the buffer size and the format string.
>
> Polo, that's quite a bit too bureaucratic,
> but where's your s-o-b for this patch? :)
Oops, here:
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
>
> Thanks,
>
> /mjt
>
next prev parent reply other threads:[~2017-05-05 7:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 10:44 [Qemu-devel] [PATCH] jazz_led: fix bad snprintf Paolo Bonzini
2017-05-03 10:51 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-05-03 11:38 ` [Qemu-devel] " Markus Armbruster
2017-05-03 11:54 ` Paolo Bonzini
2017-05-03 12:12 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-05-03 12:56 ` [Qemu-devel] " Markus Armbruster
2017-05-03 13:10 ` Paolo Bonzini
2017-05-03 13:33 ` Markus Armbruster
2017-05-05 6:24 ` Michael Tokarev
2017-05-05 7:22 ` Paolo Bonzini [this message]
2017-05-05 9:47 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578c614d-741f-bac5-b42a-86e61a6658e4@redhat.com \
--to=pbonzini@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).