qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] checkpatch: fix break by renaming README
@ 2016-07-21 10:15 Peter Xu
  2016-07-21 14:37 ` Eric Blake
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Xu @ 2016-07-21 10:15 UTC (permalink / raw)
  To: qemu-devel; +Cc: peterx

Without this, we cannot run checkpatch.pl under QEMU root directory.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index afa7f79..8247305 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -286,7 +286,7 @@ sub top_of_kernel_tree {
 
 	my @tree_check = (
 		"COPYING", "MAINTAINERS", "Makefile",
-		"README", "docs", "VERSION",
+		"README.md", "docs", "VERSION",
 		"vl.c"
 	);
 
-- 
2.4.11

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] checkpatch: fix break by renaming README
  2016-07-21 10:15 [Qemu-devel] [PATCH] checkpatch: fix break by renaming README Peter Xu
@ 2016-07-21 14:37 ` Eric Blake
  2016-07-22  3:26   ` Peter Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2016-07-21 14:37 UTC (permalink / raw)
  To: Peter Xu, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On 07/21/2016 04:15 AM, Peter Xu wrote:
> Without this, we cannot run checkpatch.pl under QEMU root directory.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NACK; see
https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg04850.html for
a more complete solution

> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index afa7f79..8247305 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -286,7 +286,7 @@ sub top_of_kernel_tree {
>  
>  	my @tree_check = (
>  		"COPYING", "MAINTAINERS", "Makefile",
> -		"README", "docs", "VERSION",
> +		"README.md", "docs", "VERSION",
>  		"vl.c"
>  	);
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] checkpatch: fix break by renaming README
  2016-07-21 14:37 ` Eric Blake
@ 2016-07-22  3:26   ` Peter Xu
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Xu @ 2016-07-22  3:26 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel

On Thu, Jul 21, 2016 at 08:37:01AM -0600, Eric Blake wrote:
> On 07/21/2016 04:15 AM, Peter Xu wrote:
> > Without this, we cannot run checkpatch.pl under QEMU root directory.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  scripts/checkpatch.pl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> NACK; see
> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg04850.html for
> a more complete solution

Yeah it's already reverted and it's working in master. Thanks for the
pointer. :)

-- peterx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-22  3:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-21 10:15 [Qemu-devel] [PATCH] checkpatch: fix break by renaming README Peter Xu
2016-07-21 14:37 ` Eric Blake
2016-07-22  3:26   ` Peter Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).