From: Eric Blake <eblake@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect()
Date: Thu, 21 Jul 2016 08:41:17 -0600 [thread overview]
Message-ID: <5790DF0D.60104@redhat.com> (raw)
In-Reply-To: <1469097213-26441-2-git-send-email-caoj.fnst@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On 07/21/2016 04:33 AM, Cao jin wrote:
> It is never used, and now all connect is nonblocking via
> inet_connect_addr().
Maybe the subject line could be:
util: Drop unused inet_unblocking_connect()
but what you have isn't too bad.
>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> include/qemu/sockets.h | 3 ---
> util/qemu-sockets.c | 30 ------------------------------
> 2 files changed, 33 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-07-21 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 10:33 [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions Cao jin
2016-07-21 10:33 ` [Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect() Cao jin
2016-07-21 14:41 ` Eric Blake [this message]
2016-07-21 10:33 ` [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect() Cao jin
2016-07-21 14:42 ` Eric Blake
2016-07-21 15:39 ` Daniel P. Berrange
2016-07-22 10:34 ` Cao jin
2016-07-22 10:30 ` Daniel P. Berrange
2016-07-22 10:43 ` Cao jin
2016-07-22 10:38 ` Daniel P. Berrange
2016-07-22 11:05 ` Cao jin
2016-07-21 13:41 ` [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions Cao jin
2016-07-21 14:28 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5790DF0D.60104@redhat.com \
--to=eblake@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).