From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFBI-0003aI-Vy for qemu-devel@nongnu.org; Thu, 21 Jul 2016 10:42:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQFBD-0006wK-Qb for qemu-devel@nongnu.org; Thu, 21 Jul 2016 10:42:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFBD-0006wG-II for qemu-devel@nongnu.org; Thu, 21 Jul 2016 10:42:27 -0400 References: <1469097213-26441-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469097213-26441-3-git-send-email-caoj.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <5790DF51.8030806@redhat.com> Date: Thu, 21 Jul 2016 08:42:25 -0600 MIME-Version: 1.0 In-Reply-To: <1469097213-26441-3-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pn3Eo9RUtC8L60eSqWLHllOLlmD9H3qgr" Subject: Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Pn3Eo9RUtC8L60eSqWLHllOLlmD9H3qgr From: Eric Blake To: Cao jin , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann Message-ID: <5790DF51.8030806@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect() References: <1469097213-26441-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469097213-26441-3-git-send-email-caoj.fnst@cn.fujitsu.com> In-Reply-To: <1469097213-26441-3-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/21/2016 04:33 AM, Cao jin wrote: > It is never used, and now all connect is nonblocking via > inet_connect_addr(). >=20 Could be squashed with 1/2. In fact, if you squash it, I'd title the pat= ch: util: Drop unused *_nonblocking_connect() functions You may also want to call out which commit id rendered the functions unus= ed. > Cc: Daniel P. Berrange > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > Signed-off-by: Cao jin > --- > include/qemu/sockets.h | 3 --- > util/qemu-sockets.c | 16 ---------------- > 2 files changed, 19 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Pn3Eo9RUtC8L60eSqWLHllOLlmD9H3qgr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXkN9SAAoJEKeha0olJ0NqX8AH/31VlP3ay7eoNe3Q6bJERCYN a2E05URKfDBZZJQYTI2xL/EtS4DhgzRVmo0DI8G0TN7ziHmp/Ivli+izp9J91RfL gghReI0x5dbt97/LB8369KQWy8WcYC4IZsyeFI82GtITlRaoOHAJxmcdrCEcjVQX pEctHWynzL1sZ9Qo4XCTlPHdYlkxqpV7HdyA/xkTZ5LijwlntOMuflWa0xkDzDZ8 D6k9O3Y15RTxAHOF2909DQAuSZEQ8S8obOYzkEFrgEYwiEo4e/hug2LSdn8iMN+h Tcz0BJM2PadFh+Rp3cfZ4oomCmIJ/6hbKEQRe5vC/xkpAsfJD56Ey4SQdEOyDg8= =r3hh -----END PGP SIGNATURE----- --Pn3Eo9RUtC8L60eSqWLHllOLlmD9H3qgr--