From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQKvD-00076v-6x for qemu-devel@nongnu.org; Thu, 21 Jul 2016 16:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQKv9-0008IP-TI for qemu-devel@nongnu.org; Thu, 21 Jul 2016 16:50:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQKv9-0008IL-LQ for qemu-devel@nongnu.org; Thu, 21 Jul 2016 16:50:15 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 009297EA90 for ; Thu, 21 Jul 2016 20:50:15 +0000 (UTC) References: <20160721140030.28383-1-marcandre.lureau@redhat.com> <20160721140030.28383-4-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <57913585.4070802@redhat.com> Date: Thu, 21 Jul 2016 14:50:13 -0600 MIME-Version: 1.0 In-Reply-To: <20160721140030.28383-4-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="54gXtTd42URqXIfqcGUIl0K86twRKTgrt" Subject: Re: [Qemu-devel] [PATCH v2 03/12] monitor: register gen:false commands manually List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --54gXtTd42URqXIfqcGUIl0K86twRKTgrt From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <57913585.4070802@redhat.com> Subject: Re: [PATCH v2 03/12] monitor: register gen:false commands manually References: <20160721140030.28383-1-marcandre.lureau@redhat.com> <20160721140030.28383-4-marcandre.lureau@redhat.com> In-Reply-To: <20160721140030.28383-4-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/21/2016 08:00 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Since a few commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. >=20 > This is in preparation for removal of qapi 'middle' mode generation. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Eric Blake > --- > monitor.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > +static void qmp_init_marshal(void) > +{ > + qmp_register_command("query-qmp-schema", qmp_query_qmp_schema, > + QCO_NO_OPTIONS); > + qmp_register_command("device_add", qmp_device_add, > + QCO_NO_OPTIONS); > + qmp_register_command("netdev_add", qmp_netdev_add, > + QCO_NO_OPTIONS); Of course, if my netdev_add patch goes in first (currently on Markus' qapi-not-next branch, because we decided it was too risky for 2.7 hard freeze), then this last line is not needed. R-b still stands. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --54gXtTd42URqXIfqcGUIl0K86twRKTgrt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXkTWFAAoJEKeha0olJ0NqU4MH/jLbf23FbAW06u+HDhKvuTUM DiiIYAO22TEglbmnxl6j2oDW9u22KS8ICjdTrh8pJ31x9tiZroiaGoQ78zfid4bA PV8nn7uohOl7ROwsYiDZhaSdeFdDHiaOa8Bj70j9dF2tSxAtGCEKApPCzVs+FKIT AfqQdzaKg5sKAmmA2JEsJVljh4GSU/GZYTqBywZPl1qLFcmmGPxH65CRPTNpeKBQ 9yLpi38WbSz84b9w553WdXKQ9zNizLCuXbJ/sVCLtRqM94JQ2ymuc5+ZL0cVAHX1 Nh+q6N0f/Qg+kPC7mqMi7hWkKSt8K8H8T+0e/8Jo7Cm5z91BMhdoCNrleHXb47I= =irwf -----END PGP SIGNATURE----- --54gXtTd42URqXIfqcGUIl0K86twRKTgrt--