From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL1R-0001HS-GU for qemu-devel@nongnu.org; Thu, 21 Jul 2016 16:56:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQL1N-00011k-A4 for qemu-devel@nongnu.org; Thu, 21 Jul 2016 16:56:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL1N-00011Y-4c for qemu-devel@nongnu.org; Thu, 21 Jul 2016 16:56:41 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBBC77DD3D for ; Thu, 21 Jul 2016 20:56:39 +0000 (UTC) References: <20160721140030.28383-1-marcandre.lureau@redhat.com> <20160721140030.28383-6-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <57913706.80100@redhat.com> Date: Thu, 21 Jul 2016 14:56:38 -0600 MIME-Version: 1.0 In-Reply-To: <20160721140030.28383-6-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ViXJhuduHIdwK02igJ6QP0oSf27Bms7br" Subject: Re: [Qemu-devel] [PATCH v2 05/12] monitor: register the qapi generated commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ViXJhuduHIdwK02igJ6QP0oSf27Bms7br From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <57913706.80100@redhat.com> Subject: Re: [PATCH v2 05/12] monitor: register the qapi generated commands References: <20160721140030.28383-1-marcandre.lureau@redhat.com> <20160721140030.28383-6-marcandre.lureau@redhat.com> In-Reply-To: <20160721140030.28383-6-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/21/2016 08:00 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Stop using the so-called 'middle' mode. Instead, use qmp_find_command()= > from generated qapi commands registry. >=20 > Note: this commit requires a 'make clean' prior to make, since the > generated files do not depend on Makefile (due to a cyclic rule > introduced in 4115852bb0). >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > monitor.c | 15 ++++-- > Makefile | 2 +- > qmp-commands.hx | 143 ------------------------------------------------= -------- > vl.c | 1 + > 4 files changed, 13 insertions(+), 148 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ViXJhuduHIdwK02igJ6QP0oSf27Bms7br Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXkTcGAAoJEKeha0olJ0NqfU4H+wdZq7/pkVIqwhHMt8yBq10L nYKxSnIQwJWTYT0geSBiJdkBUz8VtagnabcYCPp8rx7KCPB0/eKalqAohyJt6HFn gO2QQi60DVdY/8xMyseLRK9kj+hNC6uS35vFXoKMPZwwnwXc+zAbQGXtkBE5PXif R15XZ5wkPWbZVKkVhHxr/NnU1ai36EcX7ny5QFxMyEA1RwdLu4RIZrv49Y4Xn7in FfhHhsu4t/7AY+zx8mdTMwEFQyvkrFF8S4zFJE6DFM9WETwrTqcF3gpFsH/jkNdQ Kn7GLnxv3qxcMhRM0zVhYQFd/miNRLAN0YlBSExS3Rrld5N2pi9KvyP3vQ2eTJY= =eziU -----END PGP SIGNATURE----- --ViXJhuduHIdwK02igJ6QP0oSf27Bms7br--