From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQb9H-0005dy-VI for qemu-devel@nongnu.org; Fri, 22 Jul 2016 10:09:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQb9D-0008K8-MM for qemu-devel@nongnu.org; Fri, 22 Jul 2016 10:09:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQb9D-0008Jr-Dy for qemu-devel@nongnu.org; Fri, 22 Jul 2016 10:09:51 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24147C05AA5E for ; Fri, 22 Jul 2016 14:09:51 +0000 (UTC) References: <1469181904-14771-1-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <5792292E.2060505@redhat.com> Date: Fri, 22 Jul 2016 08:09:50 -0600 MIME-Version: 1.0 In-Reply-To: <1469181904-14771-1-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="29bWDNJq2DxJ77gSulGRBF8Tec5QP1THB" Subject: Re: [Qemu-devel] [PATCH] block/gluster: fix doc in the qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: armbru@redhat.com, jcody@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --29bWDNJq2DxJ77gSulGRBF8Tec5QP1THB From: Eric Blake To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: armbru@redhat.com, jcody@redhat.com Message-ID: <5792292E.2060505@redhat.com> Subject: Re: [PATCH] block/gluster: fix doc in the qapi schema References: <1469181904-14771-1-git-send-email-prasanna.kalever@redhat.com> In-Reply-To: <1469181904-14771-1-git-send-email-prasanna.kalever@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/22/2016 04:05 AM, Prasanna Kumar Kalever wrote: > 1. s/@debug-level/@debug_level/ Wrong. I asked for the opposite, s/debug_level/debug-level/ > 2. rearrange the versioning > 3. s/server description/servers description/ >=20 > Signed-off-by: Prasanna Kumar Kalever > --- > qapi/block-core.json | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index f462345..5af0ffd 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1689,8 +1689,9 @@ > # > # @host_device, @host_cdrom: Since 2.1 > # > -# Since: 2.0 > # @gluster: Since 2.7 I don't think you need a blank line before this one; but that's cosmetic.= > +# > +# Since: 2.0 > ## > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > @@ -2134,9 +2135,9 @@ > # > # @path: absolute path to image file in gluster volume > # > -# @server: gluster server description > +# @server: gluster servers description This part is okay. > # > -# @debug-level: #optional libgfapi log level (default '4' which is Err= or) > +# @debug_level: #optional libgfapi log level (default '4' which is Err= or) The docs were right, it was the code below that used _ when it should use= -. Looking forward to v2; this qualifies as a bugfix, so it is safe during hard freeze (and in fact necessary, so that we aren't baking in the wrong spelling in introspection and breaking ABI to fix it later on). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --29bWDNJq2DxJ77gSulGRBF8Tec5QP1THB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXkikuAAoJEKeha0olJ0NqLYoH/ihfwKiN6Fr/pNJrBuLZuFUb 7JUHnIJbYZBuGiEi+eX1/0DlaBMXOwFhO98M5VsYqXkYa3fmKRU9RazKJn+QVNGI j+BiF7JqlleOqsgX4qcHuW9GysA+ystBv//OTz8qQxRPXoC25HrfnOwNaxi3zZoj lr7b53UtJnb54Q1PUhxX50OSfUYQDMEVGihK3h5PJwSLbU7umLgv+uOhrZx/y25M Ah8W3umLRvDLhtSE6lutbuwrcJ6hMQeBhFTRb7a7m6MbgoL4wysmDnoARs++NsWq +CQRXRZGiGF7p1grUSXCRpIWfF5zShGcs2Dr1ae1F13o483qclx4ISqkwPX+ktE= =yzz0 -----END PGP SIGNATURE----- --29bWDNJq2DxJ77gSulGRBF8Tec5QP1THB--