From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQbib-0007y6-OI for qemu-devel@nongnu.org; Fri, 22 Jul 2016 10:46:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQbiW-0000h5-QG for qemu-devel@nongnu.org; Fri, 22 Jul 2016 10:46:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQbiW-0000gm-Hu for qemu-devel@nongnu.org; Fri, 22 Jul 2016 10:46:20 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFB8FF2647 for ; Fri, 22 Jul 2016 14:46:19 +0000 (UTC) References: <1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <579231BA.9080608@redhat.com> Date: Fri, 22 Jul 2016 08:46:18 -0600 MIME-Version: 1.0 In-Reply-To: <1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EnLD9IpA7TtpqCb19gieSM07IhaPkLSMb" Subject: Re: [Qemu-devel] [PATCH for-2.7 v2] block/gluster: fix doc in the qapi schema and member name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: armbru@redhat.com, jcody@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EnLD9IpA7TtpqCb19gieSM07IhaPkLSMb From: Eric Blake To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: armbru@redhat.com, jcody@redhat.com Message-ID: <579231BA.9080608@redhat.com> Subject: Re: [PATCH for-2.7 v2] block/gluster: fix doc in the qapi schema and member name References: <1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com> In-Reply-To: <1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/22/2016 08:34 AM, Prasanna Kumar Kalever wrote: > 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-= level/ > 2. rearrange the versioning > 3. s/server description/servers description/ >=20 > Signed-off-by: Prasanna Kumar Kalever This part is fine. > v2: address review comments given by Eric Blake > v1: Initial patch But these lines... > --- =2E..should be here. They are useful to reviewers, but do not need to clutter qemu.git, so putting them after the separator lets 'git am' automatically strip them. The maintainer can probably fix that without needing a respin. > qapi/block-core.json | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 Reviewed-by: Eric Blake Must go in during hard freeze for 2.7, otherwise it would be an ABI change compared to released code. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EnLD9IpA7TtpqCb19gieSM07IhaPkLSMb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXkjG6AAoJEKeha0olJ0Nq+vEH/RKFomkKbLicuP5g4LKMCWzT eyJLrzn7T26efRpdqSKq9O2EYuAXCdCCFL96yA1SVQKnQAiNOZzApQU+Br67Nnew SJ9DZEDezjmYdonhJkfDAjVYlgRPMeNrazdsgy8S6v14pCL3Yaqh/2dW5k1ZXaTK v6H+ZjuE/IzWAfT3r37lJYOYINqrqMQyQZK8nXaH0yOgu4OBtkX4kGJMJWskN0+r v95ESFEn1BwczsFG44KVQxWF8DJoQVmn/o8LzAhlr72yZYZdZEKvq4CGV1WR2Et7 bRvPuZDFEizOQWzsXmLAU3nSSsuwrNqpe9OqRWRcudDD+4AOUk823tRtyE5Nz4Y= =7YnU -----END PGP SIGNATURE----- --EnLD9IpA7TtpqCb19gieSM07IhaPkLSMb--