From: Corey Minyard <minyard@acm.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <mlureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize
Date: Sat, 23 Jul 2016 08:18:34 -0500 [thread overview]
Message-ID: <57936EAA.7010705@acm.org> (raw)
In-Reply-To: <e22d5886-0d37-6014-d95b-9c8ad5d657c7@redhat.com>
On 07/23/2016 02:46 AM, Paolo Bonzini wrote:
>
> On 22/07/2016 21:50, minyard@acm.org wrote:
>> This has kind of opened a can of worms for me, though. Looking
>> at a lot of the devices, there is no unrealize function and that
>> can leave a lot of things hanging. And for ISA bus devices, there
>> is no way to unregister ports.
> Right, this is because they aren't hotpluggable.
>
> I should dig out the huge patchset I had to make timers statically
> allocated...
>
> Paolo
Am I correct in saying, then, that instead of adding a finalize
function to the IPMI BMC, we should instead make it not hot
pluggable? And then the rest of my patches are not really
relevant. I already have a function to set hotpluggable to
false for the BMCs, I can post that.
From what I have seen, you can unrealize devices using the
API, even if they are not hot pluggable, by setting the realized
bool. Is that ok?
-corey
next prev parent reply other threads:[~2016-07-23 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 19:50 [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 1/4] ipmi_bmc_sim: Remove an unnecessary mutex minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 2/4] wdt_i6300esb: Free timer minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 3/4] wdt_ib700: " minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 4/4] ipmi_bmc_sim: Add a proper unrealize function minyard
2016-07-23 7:46 ` [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize Paolo Bonzini
2016-07-23 13:18 ` Corey Minyard [this message]
2016-07-23 15:16 ` Paolo Bonzini
2016-07-23 18:04 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57936EAA.7010705@acm.org \
--to=minyard@acm.org \
--cc=mlureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).