From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1bQwpD-0003it-U2
	for qemu-devel@nongnu.org; Sat, 23 Jul 2016 09:18:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1bQwpC-0004AN-PD
	for qemu-devel@nongnu.org; Sat, 23 Jul 2016 09:18:39 -0400
Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:36703)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1bQwpC-0004AJ-Hn
	for qemu-devel@nongnu.org; Sat, 23 Jul 2016 09:18:38 -0400
Received: by mail-pf0-x231.google.com with SMTP id h186so49719371pfg.3
	for <qemu-devel@nongnu.org>; Sat, 23 Jul 2016 06:18:38 -0700 (PDT)
Sender: Corey Minyard <tcminyard@gmail.com>
Reply-To: minyard@acm.org
References: <1469217041-15358-1-git-send-email-minyard@acm.org>
	<e22d5886-0d37-6014-d95b-9c8ad5d657c7@redhat.com>
From: Corey Minyard <minyard@acm.org>
Message-ID: <57936EAA.7010705@acm.org>
Date: Sat, 23 Jul 2016 08:18:34 -0500
MIME-Version: 1.0
In-Reply-To: <e22d5886-0d37-6014-d95b-9c8ad5d657c7@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <mlureau@redhat.com>

On 07/23/2016 02:46 AM, Paolo Bonzini wrote:
>
> On 22/07/2016 21:50, minyard@acm.org wrote:
>> This has kind of opened a can of worms for me, though.  Looking
>> at a lot of the devices, there is no unrealize function and that
>> can leave a lot of things hanging.  And for ISA bus devices, there
>> is no way to unregister ports.
> Right, this is because they aren't hotpluggable.
>
> I should dig out the huge patchset I had to make timers statically
> allocated...
>
> Paolo
Am I correct in saying, then, that instead of adding a finalize
function to the IPMI BMC, we should instead make it not hot
pluggable?  And then the rest of my patches are not really
relevant.  I already have a function to set hotpluggable to
false for the BMCs, I can post that.

 From what I have seen, you can unrealize devices using the
API, even if they are not hot pluggable, by setting the realized
bool.  Is that ok?

-corey