From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job
Date: Tue, 10 Nov 2020 18:42:09 -0200 [thread overview]
Message-ID: <579650f6-e8a1-fa8c-c28c-566d15ef2088@redhat.com> (raw)
In-Reply-To: <20201108221925.2344515-7-philmd@redhat.com>
Once Cleber said "acceptance" wasn't a good name for those tests.
Indeed "integration" is widely used, so okay for this renaming.
On 11/8/20 8:19 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.yml | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 0ef814764a0..d4526323169 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -42,7 +42,7 @@ include:
> - find . -type f -exec touch {} +
> - make $MAKE_CHECK_ARGS
>
> -.acceptance_test_job:
> +.integration_test_job:
> extends: .native_test_job
> cache:
> key: "${CI_JOB_NAME}-cache"
> @@ -89,8 +89,8 @@ check-system-ubuntu:
> IMAGE: ubuntu2004
> MAKE_CHECK_ARGS: check
>
> -acceptance-system-ubuntu:
> - extends: .acceptance_test_job
> +integration-system-ubuntu:
> + extends: .integration_test_job
> needs:
> - job: build-system-ubuntu
> artifacts: true
> @@ -119,8 +119,8 @@ check-system-debian:
> IMAGE: debian-amd64
> MAKE_CHECK_ARGS: check
>
> -acceptance-system-debian:
> - extends: .acceptance_test_job
> +integration-system-debian:
> + extends: .integration_test_job
> needs:
> - job: build-system-debian
> artifacts: true
> @@ -150,8 +150,8 @@ check-system-fedora:
> IMAGE: fedora
> MAKE_CHECK_ARGS: check
>
> -acceptance-system-fedora:
> - extends: .acceptance_test_job
> +integration-system-fedora:
> + extends: .integration_test_job
> needs:
> - job: build-system-fedora
> artifacts: true
> @@ -181,8 +181,8 @@ check-system-centos:
> IMAGE: centos8
> MAKE_CHECK_ARGS: check
>
> -acceptance-system-centos:
> - extends: .acceptance_test_job
> +integration-system-centos:
> + extends: .integration_test_job
> needs:
> - job: build-system-centos
> artifacts: true
next prev parent reply other threads:[~2020-11-10 20:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 22:19 [PATCH v3 00/11] gitlab-ci: Allow forks to select & restrict build jobs Philippe Mathieu-Daudé
2020-11-08 22:19 ` [PATCH v3 01/11] gitlab-ci: Drop generic cache rule Philippe Mathieu-Daudé
2020-11-09 9:46 ` Thomas Huth
2020-11-08 22:19 ` [PATCH v3 02/11] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Philippe Mathieu-Daudé
2020-11-10 20:21 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 03/11] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2020-11-10 20:23 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 04/11] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2020-11-10 20:24 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 05/11] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2020-11-10 20:35 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2020-11-10 20:42 ` Wainer dos Santos Moschetta [this message]
2020-11-12 7:02 ` Thomas Huth
2020-11-12 20:31 ` Wainer dos Santos Moschetta
2020-11-16 12:56 ` Philippe Mathieu-Daudé
2020-11-23 15:36 ` Willian Rampazzo
2020-11-08 22:19 ` [PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job' Philippe Mathieu-Daudé
2020-11-09 9:52 ` Thomas Huth
2020-11-10 10:23 ` Philippe Mathieu-Daudé
2020-11-10 20:43 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 08/11] gitlab-ci: Extract common job definition as 'native_common_job' Philippe Mathieu-Daudé
2020-11-10 20:54 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 09/11] gitlab-ci: Add rules to select cross-jobs to build Philippe Mathieu-Daudé
2020-11-09 9:57 ` Thomas Huth
2020-11-08 22:19 ` [PATCH v3 10/11] gitlab-ci: Add rules to select building/testing native jobs Philippe Mathieu-Daudé
2020-11-08 22:19 ` [PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'native_build_job' Philippe Mathieu-Daudé
2020-11-09 9:59 ` Thomas Huth
2020-11-16 13:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579650f6-e8a1-fa8c-c28c-566d15ef2088@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).