From: Jason Wang <jasowang@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Dmitry Fleytman <dmitry@daynix.com>,
qemu devel <qemu-devel@nongnu.org>,
qemu trival <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning
Date: Tue, 26 Jul 2016 10:27:03 +0800 [thread overview]
Message-ID: <5796CA77.3030703@redhat.com> (raw)
In-Reply-To: <1469425667-20703-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
On 2016年07月25日 13:47, Changlong Xie wrote:
> slave:~/.xie/qemu-colo # gcc --version
> gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973]
>
> slave:~/.xie/qemu-colo # make -j8
> CC hw/net/e1000e_core.o
> hw/net/e1000e_core.c:56: warning: ‘e1000e_set_interrupt_cause’ declared inline after being called
> hw/net/e1000e_core.c:56: warning: previous declaration of ‘e1000e_set_interrupt_cause’ was here
> LINK x86_64-softmmu/qemu-system-x86_64
>
> Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
> hw/net/e1000e_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> index badb1fe..e0bd31c 100644
> --- a/hw/net/e1000e_core.c
> +++ b/hw/net/e1000e_core.c
> @@ -52,7 +52,7 @@
> second according to spec 10.2.4.2 */
> #define E1000E_MAX_TX_FRAGS (64)
>
> -static void
> +static inline void
> e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val);
>
> static inline void
Applied, thanks.
prev parent reply other threads:[~2016-07-26 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 5:47 [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning Changlong Xie
2016-07-26 2:27 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5796CA77.3030703@redhat.com \
--to=jasowang@redhat.com \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).