* [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning
@ 2016-07-25 5:47 Changlong Xie
2016-07-26 2:27 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Changlong Xie @ 2016-07-25 5:47 UTC (permalink / raw)
To: Jason Wang, Dmitry Fleytman, qemu devel, qemu trival
slave:~/.xie/qemu-colo # gcc --version
gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973]
slave:~/.xie/qemu-colo # make -j8
CC hw/net/e1000e_core.o
hw/net/e1000e_core.c:56: warning: ‘e1000e_set_interrupt_cause’ declared inline after being called
hw/net/e1000e_core.c:56: warning: previous declaration of ‘e1000e_set_interrupt_cause’ was here
LINK x86_64-softmmu/qemu-system-x86_64
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
hw/net/e1000e_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index badb1fe..e0bd31c 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -52,7 +52,7 @@
second according to spec 10.2.4.2 */
#define E1000E_MAX_TX_FRAGS (64)
-static void
+static inline void
e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val);
static inline void
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning
2016-07-25 5:47 [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning Changlong Xie
@ 2016-07-26 2:27 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2016-07-26 2:27 UTC (permalink / raw)
To: Changlong Xie, Dmitry Fleytman, qemu devel, qemu trival
On 2016年07月25日 13:47, Changlong Xie wrote:
> slave:~/.xie/qemu-colo # gcc --version
> gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973]
>
> slave:~/.xie/qemu-colo # make -j8
> CC hw/net/e1000e_core.o
> hw/net/e1000e_core.c:56: warning: ‘e1000e_set_interrupt_cause’ declared inline after being called
> hw/net/e1000e_core.c:56: warning: previous declaration of ‘e1000e_set_interrupt_cause’ was here
> LINK x86_64-softmmu/qemu-system-x86_64
>
> Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
> hw/net/e1000e_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> index badb1fe..e0bd31c 100644
> --- a/hw/net/e1000e_core.c
> +++ b/hw/net/e1000e_core.c
> @@ -52,7 +52,7 @@
> second according to spec 10.2.4.2 */
> #define E1000E_MAX_TX_FRAGS (64)
>
> -static void
> +static inline void
> e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val);
>
> static inline void
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-26 2:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25 5:47 [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning Changlong Xie
2016-07-26 2:27 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).