From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1bRsE7-0006fX-Cv
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 22:36:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1bRsE5-00043E-Cv
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 22:36:10 -0400
Message-ID: <5796CDCF.30306@cn.fujitsu.com>
Date: Tue, 26 Jul 2016 10:41:19 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com>
	<1469182567-3114-11-git-send-email-wangww.fnst@cn.fujitsu.com>
	<7e07b40d-b0b8-1a2a-e446-007316deba67@redhat.com>
In-Reply-To: <7e07b40d-b0b8-1a2a-e446-007316deba67@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v22 10/10] support replication driver in
 blockdev-add
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, Wang WeiWei <wangww.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, qemu block <qemu-block@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David
	Alan Gilbert" <dgilbert@redhat.com>, Dong Eddie <eddie.dong@intel.com>, Jiang Yunhong <yunhong.jiang@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Gonglei <arei.gonglei@huawei.com>, Wen Congyang <wency@cn.fujitsu.com>

On 07/26/2016 07:00 AM, Max Reitz wrote:
> On 22.07.2016 12:16, Wang WeiWei wrote:
>> From: Wen Congyang <wency@cn.fujitsu.com>
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
>> ---
>>   qapi/block-core.json | 19 +++++++++++++++++--
>>   1 file changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index 7f05b68..59565e9 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -248,6 +248,7 @@
>>   #       2.3: 'host_floppy' deprecated
>>   #       2.5: 'host_floppy' dropped
>>   #       2.6: 'luks' added
>> +#       2.7: 'replication' added
>
> Probably 2.8

yes

>
>>   #
>>   # @backing_file: #optional the name of the backing file (for copy-on-write)
>>   #
>> @@ -1696,8 +1697,8 @@
>>     'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
>>               'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
>>               'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
>> -            'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp',
>> -            'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>> +            'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'replication',
>> +            'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>>
>>   ##
>>   # @BlockdevOptionsFile
>> @@ -2160,6 +2161,19 @@
>>   { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
>>
>>   ##
>> +# @BlockdevOptionsReplication
>> +#
>> +# Driver specific block device options for replication
>> +#
>> +# @mode: the replication mode
>
> What about top-id?

Sorry, i'll add it in next version

>
>> +#
>> +# Since: 2.7
>
> 2.8

yes.

>
> Max
>
>> +##
>> +{ 'struct': 'BlockdevOptionsReplication',
>> +  'base': 'BlockdevOptionsGenericFormat',
>> +  'data': { 'mode': 'ReplicationMode'  } }
>> +
>> +##
>>   # @BlockdevOptions
>>   #
>>   # Options for creating a block device.  Many options are available for all
>> @@ -2224,6 +2238,7 @@
>>         'quorum':     'BlockdevOptionsQuorum',
>>         'raw':        'BlockdevOptionsGenericFormat',
>>   # TODO rbd: Wait for structured options
>> +      'replication':'BlockdevOptionsReplication',
>>   # TODO sheepdog: Wait for structured options
>>   # TODO ssh: Should take InetSocketAddress for 'host'?
>>         'tftp':       'BlockdevOptionsFile',
>>
>
>