From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1bRsWD-000496-J3
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 22:54:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1bRsWB-0007j4-MZ
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 22:54:52 -0400
Message-ID: <5796D238.3060008@cn.fujitsu.com>
Date: Tue, 26 Jul 2016 11:00:08 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com>
	<57958B22.40507@cn.fujitsu.com>
	<20160725143458.GC14676@stefanha-x1.localdomain>
In-Reply-To: <20160725143458.GC14676@stefanha-x1.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v22 00/10] Block replication for continuous
 checkpoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Wang WeiWei <wangww.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, qemu block <qemu-block@nongnu.org>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan
	Gilbert" <dgilbert@redhat.com>, Dong Eddie <eddie.dong@intel.com>, Jiang Yunhong <yunhong.jiang@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Gonglei <arei.gonglei@huawei.com>, Wen Congyang <wency@cn.fujitsu.com>

On 07/25/2016 10:34 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote:
>> COLO block is the necessary prerequisite of COLO framework and COLO network,
>> what are blocked by these patchsets now.
>>
>> Since v19, Stefan said he had reviewed most part of this patchsets. So, this
>> series *REALLY* need more comments from all of you.
>>
>> I've ping so many times, but no response until now. All i have to do is
>> rebase them to the lastest code.
>>
>> Do you have time to review this?  Any response would be appreciate.
>
> There has been no review activity for a long time.  You have been
> patient and addressed issues that I raised back when I reviewed the
> series.  Both you and I have pinged maintainers numerous times.  It's
> not fair to keep this out of tree at this stage.
>
> Since no one else seems to care I suggest rebasing/testing a final time
> with the following changes:
>
> 1. Update the MAINTAINERS for new files you are adding.
> 2. Make the feature optional in ./configure so distros that don't feel
>     comfortable shipping it yet can easily disable it:
>
>       $ ./configure --disable-replication && make -j4
>

Will follow you advise in next version.

> Then I will merge it if there are no comments.
>
> Stefan
>