From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Liam Merwick <liam.merwick@oracle.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Maran Wilson <maran.wilson@oracle.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Eric Blake <eblake@redhat.com>,
Richard Henderson <rth@twiddle.net>,
George Kennedy <george.kennedy@oracle.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg
Date: Thu, 17 Jan 2019 18:57:18 +0100 [thread overview]
Message-ID: <5797a98c-f428-b3a1-eef3-497f86590d65@redhat.com> (raw)
In-Reply-To: <20190117161344.xxqbtbet6bnk6imb@steredhat>
On 17/01/19 17:13, Stefano Garzarella wrote:
> On Thu, Jan 17, 2019 at 04:18:00PM +0100, Paolo Bonzini wrote:
>> On 17/01/19 16:05, Stefano Garzarella wrote:
>>>> That's part of what I didn't quite understand.
>>>> pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all'
>>>> target in pc-bios/optionrom/Makefile) are in .gitignore.
>>>>
>>>> Also, should pvh.bin be added to BLOBS in Makefile like those files?
>>> Yes, indeed I added pvh.bin to BLOBS in patch 3/5 and I committed the
>>> binary file in /pc-bios/ (note: not in /pc-bios/optionrom/ where it is
>>> compiled, maybe is here the confusion, but I following what was done for
>>> the other option roms)
>>
>> Nevermind---I was totally sure .bin files are committed. Though perhaps
>> they should, since non-x86 binaries are.
>
> They are committed (in /pc-bios/) but not were they are compiled
> (in /pc-bios/optionrom/).
Oh, I see. Sorry if I'm so dumb sometimes...
Paolo
next prev parent reply other threads:[~2019-01-17 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:02 [Qemu-devel] [PATCH v4 0/5] pvh: add new PVH option rom Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 1/5] linuxboot_dma: remove duplicate definitions of FW_CFG Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 2/5] linuxboot_dma: move common functions in a new header Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 3/5] optionrom: add new PVH option rom Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 4/5] hw/i386/pc: use " Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg Stefano Garzarella
2019-01-17 10:19 ` Stefan Hajnoczi
2019-01-17 14:33 ` Liam Merwick
2019-01-17 14:37 ` Paolo Bonzini
2019-01-17 14:52 ` Liam Merwick
2019-01-17 15:05 ` Stefano Garzarella
2019-01-17 15:18 ` Paolo Bonzini
2019-01-17 16:13 ` Stefano Garzarella
2019-01-17 17:57 ` Paolo Bonzini [this message]
2019-01-17 14:53 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5797a98c-f428-b3a1-eef3-497f86590d65@redhat.com \
--to=pbonzini@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=george.kennedy@oracle.com \
--cc=liam.merwick@oracle.com \
--cc=maran.wilson@oracle.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).