From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bSgp2-0003P8-5w
	for qemu-devel@nongnu.org; Thu, 28 Jul 2016 04:37:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bSgox-0004r1-L5
	for qemu-devel@nongnu.org; Thu, 28 Jul 2016 04:37:40 -0400
Received: from [59.151.112.132] (port=29252 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bSgox-0004qS-8B
	for qemu-devel@nongnu.org; Thu, 28 Jul 2016 04:37:35 -0400
References: <1469691571-10819-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1469691571-10819-3-git-send-email-caoj.fnst@cn.fujitsu.com>
	<20160728080819.GD22677@redhat.com>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <5799C5FF.7090200@cn.fujitsu.com>
Date: Thu, 28 Jul 2016 16:44:47 +0800
MIME-Version: 1.0
In-Reply-To: <20160728080819.GD22677@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] util: fix some coding style issue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>



On 07/28/2016 04:08 PM, Daniel P. Berrange wrote:
> On Thu, Jul 28, 2016 at 03:39:30PM +0800, Cao jin wrote:
>> Fix some coding style issues found in removing NonBlockingConnectHandler.
>>
>> Cc: Daniel P. Berrange <berrange@redhat.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>>   util/qemu-sockets.c | 16 +++++++++++-----
>>   1 file changed, 11 insertions(+), 5 deletions(-)
>
> Reviwed-by: Daniel P. Berrange <berrange@redhat.com>
>
>
>> @@ -443,12 +443,16 @@ static int inet_dgram_saddr(InetSocketAddress *sraddr,
>>       return sock;
>>
>>   err:
>> -    if (-1 != sock)
>> +    if (-1 != sock) {
>
> I'd probably fix the yoda-conditional here too. ie sock != -1 instead.
>
Just find this file mixes yoda-condition and non-yoda-condition.
ok, I can do it, v2 on the way.

-- 
Yours Sincerely,

Cao jin